Changeset 227702 in webkit

Timestamp:

Jan 26, 2018 4:45:43 PM (6 years ago)

Author:

dino@apple.com

Message:

REGRESSION (r222961): Clear function not clearing whole screen when antialias is set to false
​https://bugs.webkit.org/show_bug.cgi?id=179368
<rdar://problem/36111549>

Reviewed by Sam Weinig.

When we changed from using a CAOpenGLLayer to a regular CALayer, we should
have also swapped the "opaque" property to "contentsOpaque".

Covered by the existing test: fast/canvas/webgl/context-attributes-alpha.html
(when run on some hardware!)

• platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer initWithGraphicsContext3D:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cocoa/WebGLLayer.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-01-26  Dean Jackson  <dino@apple.com>
+
+        REGRESSION (r222961): Clear function not clearing whole screen when antialias is set to false
+        https://bugs.webkit.org/show_bug.cgi?id=179368
+        <rdar://problem/36111549>
+
+        Reviewed by Sam Weinig.
+
+        When we changed from using a CAOpenGLLayer to a regular CALayer, we should
+        have also swapped the "opaque" property to "contentsOpaque".
+
+        Covered by the existing test: fast/canvas/webgl/context-attributes-alpha.html
+        (when run on some hardware!)
+
+        * platform/graphics/cocoa/WebGLLayer.mm:
+        (-[WebGLLayer initWithGraphicsContext3D:]):
+
 2018-01-26  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm

@@ -55 +55 @@
     _devicePixelRatio = context->getContextAttributes().devicePixelRatio;
 #if PLATFORM(MAC)
-    if (!context->getContextAttributes().alpha)
-        self.opaque = YES;
+    self.contentsOpaque = !context->getContextAttributes().alpha;
     self.transform = CATransform3DIdentity;
     self.contentsScale = _devicePixelRatio;