Changeset 227962 in webkit

Timestamp:

Feb 1, 2018 6:03:45 AM (6 years ago)

Author:

fred.wang@free.fr

Message:

Rewrite fast/events/scroll-in-scaled-page-with-overflow-hidden.html to conform with CSSOM View
​https://bugs.webkit.org/show_bug.cgi?id=182287

Patch by Frederic Wang <​fwang@igalia.com> on 2018-02-01
Reviewed by Antonio Gomes.

Per the CSSOM View specification, it is wrong to use document.body.scrollTop to retrieve the
vertical offset of the viewport in this test, because the body is potentially scrollable.
This commit relies on window.scrollY instead so that the test still works after bug 5991.

• fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt:
• fast/events/scroll-in-scaled-page-with-overflow-hidden.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt (modified) (1 diff)
• fast/events/scroll-in-scaled-page-with-overflow-hidden.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-02-01  Frederic Wang  <fwang@igalia.com>
+
+        Rewrite fast/events/scroll-in-scaled-page-with-overflow-hidden.html to conform with CSSOM View
+        https://bugs.webkit.org/show_bug.cgi?id=182287
+
+        Reviewed by Antonio Gomes.
+
+        Per the CSSOM View specification, it is wrong to use document.body.scrollTop to retrieve the
+        vertical offset of the viewport in this test, because the body is potentially scrollable.
+        This commit relies on window.scrollY instead so that the test still works after bug 5991.
+
+        * fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt:
+        * fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
+
 2018-02-01  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt

@@ -1 +1 @@
 This tests that a usually overflow: hidden viewport should be scrollable when scaled. Otherwise, you can't get to content you would have been able to get to had you not been zoomed it.
-PASS window.document.body.scrollTop is 0
-PASS window.document.body.scrollTop is 100
+PASS window.scrollY is 0
+PASS window.scrollY is 100
 PASS successfullyParsed is true
 

trunk/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html

@@ -28 +28 @@
             window.internals.setPageScaleFactor(2, 0, 0);
 
-        shouldBe("window.document.body.scrollTop", "0");
+        // Note that with CSSOMViewScrollingAPI enabled, the HTML body is potentially scrollable.
+        // Hence document.scrollingElement is null and we can't use document.body.scrollTop to
+        // retrieve the vertical scroll offset of the viewport.
+        // See https://drafts.csswg.org/cssom-view/#potentially-scrollable,
+        // https://drafts.csswg.org/cssom-view/#dom-document-scrollingelement
+        // and https://drafts.csswg.org/cssom-view/#dom-element-scrolltop
+        shouldBe("window.scrollY", "0");
 
         document.body.onscroll = function() {
-            shouldBe("window.document.body.scrollTop", "100");
+            shouldBe("window.scrollY", "100");
             finishJSTest();
         }