Changeset 227969 in webkit

Timestamp:

Feb 1, 2018 9:22:35 AM (6 years ago)

Author:

Yusuke Suzuki

Message:

Structured cloning a Symbol should throw
​https://bugs.webkit.org/show_bug.cgi?id=182380

Reviewed by Darin Adler.

Source/WebCore:

Test: js/dom/post-message-symbol.html

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
Structured cloning should throw "DataCloneError" DOMException if it finds Symbol.
Remove unused isNumber() case. It is done in dumpImmediate.
(WebCore::CloneSerializer::serializeUndefined): Deleted.
(WebCore::CloneSerializer::serializeBoolean): Deleted.
(WebCore::CloneSerializer::serializeNumber): Deleted.
Remove unused functions.

LayoutTests:

• js/dom/post-message-symbol-expected.txt: Added.
• js/dom/post-message-symbol.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/dom/post-message-symbol-expected.txt (added)
• LayoutTests/js/dom/post-message-symbol.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/SerializedScriptValue.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-02-01  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        Structured cloning a Symbol should throw
+        https://bugs.webkit.org/show_bug.cgi?id=182380
+
+        Reviewed by Darin Adler.
+
+        * js/dom/post-message-symbol-expected.txt: Added.
+        * js/dom/post-message-symbol.html: Added.
+
 2018-02-01  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-01  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        Structured cloning a Symbol should throw
+        https://bugs.webkit.org/show_bug.cgi?id=182380
+
+        Reviewed by Darin Adler.
+
+        Test: js/dom/post-message-symbol.html
+
+        * bindings/js/SerializedScriptValue.cpp:
+        (WebCore::CloneSerializer::dumpIfTerminal):
+        Structured cloning should throw "DataCloneError" DOMException if it finds Symbol.
+        Remove unused `isNumber()` case. It is done in dumpImmediate.
+        (WebCore::CloneSerializer::serializeUndefined): Deleted.
+        (WebCore::CloneSerializer::serializeBoolean): Deleted.
+        (WebCore::CloneSerializer::serializeNumber): Deleted.
+        Remove unused functions.
+
 2018-02-01  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp

@@ -562 +562 @@
     }
 
-    static void serializeUndefined(Vector<uint8_t>& out)
-    {
-        writeLittleEndian(out, CurrentVersion);
-        writeLittleEndian<uint8_t>(out, UndefinedTag);
-    }
-
-    static void serializeBoolean(bool value, Vector<uint8_t>& out)
-    {
-        writeLittleEndian(out, CurrentVersion);
-        writeLittleEndian<uint8_t>(out, value ? TrueTag : FalseTag);
-    }
-
-    static void serializeNumber(double value, Vector<uint8_t>& out)
-    {
-        writeLittleEndian(out, CurrentVersion);
-        writeLittleEndian<uint8_t>(out, DoubleTag);
-        union {
-            double d;
-            int64_t i;
-        } u;
-        u.d = value;
-        writeLittleEndian(out, u.i);
-    }
-
 private:
     typedef HashMap<JSObject*, uint32_t> ObjectPool;
@@ -904 +880 @@
             return true;
         }
+        ASSERT(value.isCell());
 
         if (value.isString()) {
@@ -910 +887 @@
         }
 
-        if (value.isNumber()) {
-            write(DoubleTag);
-            write(value.asNumber());
+        if (value.isSymbol()) {
+            code = SerializationReturnCode::DataCloneError;
             return true;
         }