Changeset 228185 in webkit

Timestamp:

Feb 6, 2018 11:36:40 AM (6 years ago)

Author:

graouts@webkit.org

Message:

[Modern Media Controls] Test at media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html fails
​https://bugs.webkit.org/show_bug.cgi?id=182425

Reviewed by Dean Jackson.

Source/WebCore:

This test failed because the controls bar would not hit test at the moment we synthesized a mousemove over the controls bar as the first step towards
synthesizing a click on the controls bar to dismiss the tracks panel. Indeed, it would have "pointer-events" set to "none" until the tracks panel was
dismissed, which would only happen after the click event had been propagated. All we need to do is to ensure that none of the controls within the controls
bar get activated as a result of clicking over them when the tracks panel is visible, so we instead set "pointer-events" to "none" on all children of a
controls bar rather than the controls bar itself, which can thus still hit test.

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls.shows-tracks-panel > .controls-bar > *,):
(.media-controls.shows-tracks-panel > .controls-bar,): Deleted.

LayoutTests:

Turn the test back on now that it works.

• platform/mac/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-02-06  Antoine Quint  <graouts@apple.com>
+
+        [Modern Media Controls] Test at media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=182425
+
+        Reviewed by Dean Jackson.
+
+        Turn the test back on now that it works.
+
+        * platform/mac/TestExpectations:
+
 2018-02-06  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1463 +1463 @@
 webkit.org/b/178126 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
 webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
-webkit.org/b/182425 media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html [ Failure ]
 
 # This test relies on the control overlay not being visible in the top left. But the test now fails on Mac because

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-06  Antoine Quint  <graouts@apple.com>
+
+        [Modern Media Controls] Test at media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=182425
+
+        Reviewed by Dean Jackson.
+
+        This test failed because the controls bar would not hit test at the moment we synthesized a mousemove over the controls bar as the first step towards
+        synthesizing a click on the controls bar to dismiss the tracks panel. Indeed, it would have "pointer-events" set to "none" until the tracks panel was
+        dismissed, which would only happen after the click event had been propagated. All we need to do is to ensure that none of the controls within the controls
+        bar get activated as a result of clicking over them when the tracks panel is visible, so we instead set "pointer-events" to "none" on all children of a
+        controls bar rather than the controls bar itself, which can thus still hit test.
+
+        * Modules/modern-media-controls/controls/media-controls.css:
+        (.media-controls.shows-tracks-panel > .controls-bar > *,):
+        (.media-controls.shows-tracks-panel > .controls-bar,): Deleted.
+
 2018-02-06  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css

@@ -98 +98 @@
 }
 
-.media-controls.shows-tracks-panel > .controls-bar,
+.media-controls.shows-tracks-panel > .controls-bar > *,
 .media-controls.shows-tracks-panel > button {
     pointer-events: none;