Changeset 228265 in webkit

Timestamp:

Feb 8, 2018 2:14:01 AM (6 years ago)

Author:

Philippe Normand

Message:

[GStreamer][WebAudio] No need for version check in each loop iteration
​https://bugs.webkit.org/show_bug.cgi?id=182577

Reviewed by Xabier Rodriguez Calvar.

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init): Detect version once only, when creating the element.
(webKitWebAudioSrcLoop): Use boolean variable instead of checking the version every time.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-08  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer][WebAudio] No need for version check in each loop iteration
+        https://bugs.webkit.org/show_bug.cgi?id=182577
+
+        Reviewed by Xabier Rodriguez Calvar.
+
+        * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+        (webkit_web_audio_src_init): Detect version once only, when creating the element.
+        (webKitWebAudioSrcLoop): Use boolean variable instead of checking the version every time.
+
 2018-02-08  Frederic Wang  <fwang@igalia.com>
 

trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp

@@ -70 +70 @@
 
     GRefPtr<GstBufferPool> pool;
+
+    bool enableGapBufferSupport;
 };
 
@@ -193 +195 @@
     g_rec_mutex_init(&priv->mutex);
     priv->task = adoptGRef(gst_task_new(reinterpret_cast<GstTaskFunction>(webKitWebAudioSrcLoop), src, nullptr));
+
+    // GAP buffer support is enabled only for GStreamer 1.12.5 because of a
+    // memory leak that was fixed in that version.
+    // https://bugzilla.gnome.org/show_bug.cgi?id=793067
+    priv->enableGapBufferSupport = webkitGstCheckVersion(1, 12, 5);
 
     gst_task_set_lock(priv->task.get(), &priv->mutex);
@@ -354 +361 @@
         unmapGstBuffer(buffer.get());
 
-        // This is enabled only for GStreamer 1.12.5 because of a memory leak that was fixed in that version.
-        // https://bugzilla.gnome.org/show_bug.cgi?id=793067
-        if (webkitGstCheckVersion(1, 12, 5)) {
-            if (priv->bus->channel(i)->isSilent())
-                GST_BUFFER_FLAG_SET(buffer.get(), GST_BUFFER_FLAG_GAP);
-        }
+        if (priv->enableGapBufferSupport && priv->bus->channel(i)->isSilent())
+            GST_BUFFER_FLAG_SET(buffer.get(), GST_BUFFER_FLAG_GAP);
 
         if (failed)