Changeset 228305 in webkit

Timestamp:

Feb 8, 2018 5:58:23 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[Meta][Win] Support ICU 59.1+
​https://bugs.webkit.org/show_bug.cgi?id=181004

Patch by Fujii Hironori <Fujii Hironori> on 2018-02-08
Reviewed by Alex Christensen.

ICU 59 changed the type of UChar from wchar_t to char16_t on
Windows. We need a lot of conversions between UChar* and wchar_t*
to call Windows API because it takes string as wchar_t*.

Fortunately, ICU is configurable to define UChar as wchar_t as
well as the prior ICU.
<​http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>

• Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsWin.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Meta][Win] Support ICU 59.1+
+        https://bugs.webkit.org/show_bug.cgi?id=181004
+
+        Reviewed by Alex Christensen.
+
+        ICU 59 changed the type of UChar from wchar_t to char16_t on
+        Windows. We need a lot of conversions between UChar* and wchar_t*
+        to call Windows API because it takes string as wchar_t*.
+
+        Fortunately, ICU is configurable to define UChar as wchar_t as
+        well as the prior ICU.
+        <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
+
+        * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
+
 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/cmake/OptionsWin.cmake

@@ -146 +146 @@
 
 find_package(ICU REQUIRED)
+add_definitions(-DUCHAR_TYPE=wchar_t)