Changeset 228949 in webkit

Timestamp:

Feb 23, 2018 8:16:27 AM (6 years ago)

Author:

Alan Bujtas

Message:

[RenderTreeBuilder] Move RenderFullScreen::createPlaceholder to RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=183027
<rdar://problem/37773058>

Reviewed by Antti Koivisto.

No change in functionality.

• dom/Document.cpp:

(WebCore::Document::setFullScreenRenderer):

• dom/Document.h:
• rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreenPlaceholder::RenderFullScreenPlaceholder):
(WebCore::RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder const):
(WebCore::RenderFullScreen::wrapNewRenderer):
(WebCore::RenderFullScreen::wrapExistingRenderer):
(): Deleted.
(WebCore::RenderFullScreen::createPlaceholder): Deleted.

• rendering/RenderFullScreen.h:
• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::createPlaceholderForFullScreen):

• rendering/updating/RenderTreeBuilder.h:
• rendering/updating/RenderTreeBuilderFullScreen.cpp:

(WebCore::RenderTreeBuilder::FullScreen::createPlaceholder):

• rendering/updating/RenderTreeBuilderFullScreen.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)
• dom/Document.h (modified) (1 diff)
• rendering/RenderFullScreen.cpp (modified) (4 diffs)
• rendering/RenderFullScreen.h (modified) (3 diffs)
• rendering/updating/RenderTreeBuilder.cpp (modified) (1 diff)
• rendering/updating/RenderTreeBuilder.h (modified) (1 diff)
• rendering/updating/RenderTreeBuilderFullScreen.cpp (modified) (1 diff)
• rendering/updating/RenderTreeBuilderFullScreen.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-23  Zalan Bujtas  <zalan@apple.com>
+
+        [RenderTreeBuilder] Move RenderFullScreen::createPlaceholder to RenderTreeBuilder
+        https://bugs.webkit.org/show_bug.cgi?id=183027
+        <rdar://problem/37773058>
+
+        Reviewed by Antti Koivisto.
+
+        No change in functionality.
+
+        * dom/Document.cpp:
+        (WebCore::Document::setFullScreenRenderer):
+        * dom/Document.h:
+        * rendering/RenderFullScreen.cpp:
+        (WebCore::RenderFullScreenPlaceholder::RenderFullScreenPlaceholder):
+        (WebCore::RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder const):
+        (WebCore::RenderFullScreen::wrapNewRenderer):
+        (WebCore::RenderFullScreen::wrapExistingRenderer):
+        (): Deleted.
+        (WebCore::RenderFullScreen::createPlaceholder): Deleted.
+        * rendering/RenderFullScreen.h:
+        * rendering/updating/RenderTreeBuilder.cpp:
+        (WebCore::RenderTreeBuilder::createPlaceholderForFullScreen):
+        * rendering/updating/RenderTreeBuilder.h:
+        * rendering/updating/RenderTreeBuilderFullScreen.cpp:
+        (WebCore::RenderTreeBuilder::FullScreen::createPlaceholder):
+        * rendering/updating/RenderTreeBuilderFullScreen.h:
+
 2018-02-23  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -6307 +6307 @@
 }
 
-void Document::setFullScreenRenderer(RenderTreeBuilder& builder, RenderFullScreen* renderer)
-{
-    if (renderer == m_fullScreenRenderer)
-        return;
-
-    if (renderer) {
-        if (m_savedPlaceholderRenderStyle)
-            renderer->createPlaceholder(WTFMove(m_savedPlaceholderRenderStyle), m_savedPlaceholderFrameRect);
-        else if (m_fullScreenRenderer && m_fullScreenRenderer->placeholder()) {
-            auto* placeholder = m_fullScreenRenderer->placeholder();
-            renderer->createPlaceholder(RenderStyle::clonePtr(placeholder->style()), placeholder->frameRect());
-        }
+void Document::setFullScreenRenderer(RenderTreeBuilder& builder, RenderFullScreen& renderer)
+{
+    if (&renderer == m_fullScreenRenderer)
+        return;
+
+    if (m_savedPlaceholderRenderStyle)
+        builder.createPlaceholderForFullScreen(renderer, WTFMove(m_savedPlaceholderRenderStyle), m_savedPlaceholderFrameRect);
+    else if (m_fullScreenRenderer && m_fullScreenRenderer->placeholder()) {
+        auto* placeholder = m_fullScreenRenderer->placeholder();
+        builder.createPlaceholderForFullScreen(renderer, RenderStyle::clonePtr(placeholder->style()), placeholder->frameRect());
     }
 

trunk/Source/WebCore/dom/Document.h

@@ -1132 +1132 @@
     WEBCORE_EXPORT void webkitDidExitFullScreenForElement(Element*);
     
-    void setFullScreenRenderer(RenderTreeBuilder&, RenderFullScreen*);
+    void setFullScreenRenderer(RenderTreeBuilder&, RenderFullScreen&);
     RenderFullScreen* fullScreenRenderer() const { return m_fullScreenRenderer.get(); }
 

trunk/Source/WebCore/rendering/RenderFullScreen.cpp

@@ -39 +39 @@
 WTF_MAKE_ISO_ALLOCATED_IMPL(RenderFullScreen);
 
-class RenderFullScreenPlaceholder final : public RenderBlockFlow {
-    WTF_MAKE_ISO_ALLOCATED(RenderFullScreenPlaceholder);
-public:
-    RenderFullScreenPlaceholder(Document& document, RenderStyle&& style)
-        : RenderBlockFlow(document, WTFMove(style))
-    {
-    }
+RenderFullScreenPlaceholder::RenderFullScreenPlaceholder(Document& document, RenderStyle&& style)
+    : RenderBlockFlow(document, WTFMove(style))
+{
+}
 
-private:
-    bool isRenderFullScreenPlaceholder() const override { return true; }
-};
+bool RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder() const
+{
+    return true;
+}
 
 WTF_MAKE_ISO_ALLOCATED_IMPL(RenderFullScreenPlaceholder);
@@ -102 +100 @@
     fullscreenRenderer.setNeedsLayoutAndPrefWidthsRecalc();
 
-    document.setFullScreenRenderer(builder, &fullscreenRenderer);
+    document.setFullScreenRenderer(builder, fullscreenRenderer);
 
     return newFullscreenRenderer;
@@ -139 +137 @@
     fullscreenRenderer.setNeedsLayoutAndPrefWidthsRecalc();
 
-    document.setFullScreenRenderer(builder, &fullscreenRenderer);
+    document.setFullScreenRenderer(builder, fullscreenRenderer);
 }
 
@@ -186 +184 @@
 }
 
-void RenderFullScreen::createPlaceholder(std::unique_ptr<RenderStyle> style, const LayoutRect& frameRect)
-{
-    if (style->width().isAuto())
-        style->setWidth(Length(frameRect.width(), Fixed));
-    if (style->height().isAuto())
-        style->setHeight(Length(frameRect.height(), Fixed));
-
-    if (m_placeholder) {
-        m_placeholder->setStyle(WTFMove(*style));
-        return;
-    }
-
-    if (!parent())
-        return;
-
-    auto newPlaceholder = createRenderer<RenderFullScreenPlaceholder>(document(), WTFMove(*style));
-    newPlaceholder->initializeStyle();
-
-    m_placeholder = makeWeakPtr(*newPlaceholder);
-
-    RenderTreeBuilder::current()->attach(*parent(), WTFMove(newPlaceholder), this);
-    parent()->setNeedsLayoutAndPrefWidthsRecalc();
-}
-
 }
 

trunk/Source/WebCore/rendering/RenderFullScreen.h

@@ -27 +27 @@
 #if ENABLE(FULLSCREEN_API)
 
+#include "RenderBlockFlow.h"
 #include "RenderFlexibleBox.h"
 
@@ -40 +41 @@
 
     RenderBlock* placeholder() { return m_placeholder.get(); }
-    void createPlaceholder(std::unique_ptr<RenderStyle>, const LayoutRect& frameRect);
+    void setPlaceholder(RenderBlock& placeholder) { m_placeholder = makeWeakPtr(placeholder); }
 
     static RenderPtr<RenderFullScreen> wrapNewRenderer(RenderTreeBuilder&, RenderPtr<RenderElement>, RenderElement& parent, Document&);
@@ -56 +57 @@
 };
 
+class RenderFullScreenPlaceholder final : public RenderBlockFlow {
+    WTF_MAKE_ISO_ALLOCATED(RenderFullScreenPlaceholder);
+public:
+    RenderFullScreenPlaceholder(Document&, RenderStyle&&);
+
+private:
+    bool isRenderFullScreenPlaceholder() const override;
+};
+
 } // namespace WebCore
 

trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

@@ -359 +359 @@
 }
 
+#if ENABLE(FULLSCREEN_API)
+void RenderTreeBuilder::createPlaceholderForFullScreen(RenderFullScreen& renderer, std::unique_ptr<RenderStyle> style, const LayoutRect& frameRect)
+{
+    fullScreenBuilder().createPlaceholder(renderer, WTFMove(style), frameRect);
+}
+#endif
+
 void RenderTreeBuilder::attachToRenderElement(RenderElement& parent, RenderPtr<RenderObject> child, RenderObject* beforeChild)
 {

trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h

@@ -55 +55 @@
     void updateAfterDescendants(RenderElement&);
     void destroyAndCleanUpAnonymousWrappers(RenderObject& child);
+
+#if ENABLE(FULLSCREEN_API)
+    void createPlaceholderForFullScreen(RenderFullScreen&, std::unique_ptr<RenderStyle>, const LayoutRect&);
+#endif
 
     void childFlowStateChangesAndAffectsParentBlock(RenderElement& child);

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFullScreen.cpp

@@ -38 +38 @@
 }
 
+void RenderTreeBuilder::FullScreen::createPlaceholder(RenderFullScreen& renderer, std::unique_ptr<RenderStyle> style, const LayoutRect& frameRect)
+{
+    if (style->width().isAuto())
+        style->setWidth(Length(frameRect.width(), Fixed));
+    if (style->height().isAuto())
+        style->setHeight(Length(frameRect.height(), Fixed));
+
+    if (auto* placeHolder = renderer.placeholder()) {
+        placeHolder->setStyle(WTFMove(*style));
+        return;
+    }
+
+    if (!renderer.parent())
+        return;
+
+    auto newPlaceholder = createRenderer<RenderFullScreenPlaceholder>(renderer.document(), WTFMove(*style));
+    newPlaceholder->initializeStyle();
+
+    renderer.setPlaceholder(*newPlaceholder);
+
+    m_builder.attach(*renderer.parent(), WTFMove(newPlaceholder), &renderer);
+    renderer.parent()->setNeedsLayoutAndPrefWidthsRecalc();
+}
+
 void RenderTreeBuilder::FullScreen::cleanupOnDestroy(RenderFullScreen& fullScreenRenderer)
 {

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFullScreen.h

@@ -39 +39 @@
     FullScreen(RenderTreeBuilder&);
 
+    void createPlaceholder(RenderFullScreen&, std::unique_ptr<RenderStyle>, const LayoutRect&);
     void cleanupOnDestroy(RenderFullScreen&);