Changeset 229286 in webkit


Ignore:
Timestamp:
Mar 5, 2018 10:15:48 AM (6 years ago)
Author:
Chris Dumez
Message:

imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html times out with async policy delegates
​https://bugs.webkit.org/show_bug.cgi?id=183297

Patch by Ali Juma <​ajuma@chromium.org> on 2018-03-05
Reviewed by Chris Dumez.

Source/WebCore:

When a FrameLoader's policy document loader is cleared after receiving a navigation policy decision
to not continue loading, we still need to trigger a check for load completion, since this loader or
an ancestor loader may have been in state isLoadingInAPISense only because of the existence of
the just-cleared policy document loader. Without triggering this check, these loaders may never
call WebFrameLoaderClient::dispatchDidFinishLoad.

Test: http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

LayoutTests:

Add layout test coverage. Copy expectations from the existing sync-policy version of the test.

  • http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
  • http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html: Added.
  • http/wpt/html/semantics/text-level-semantics/the-a-element/resources/a-download-404.html: Added.
  • platform/ios-wk2/http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
  • platform/mac-wk1/http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
  • platform/win/http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
  • platform/wpe/TestExpectations:
Location:
trunk
Files:
23 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r229285 r229286  
     12018-03-05  Ali Juma  <ajuma@chromium.org>
     2
     3        imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html times out with async policy delegates
     4        https://bugs.webkit.org/show_bug.cgi?id=183297
     5
     6        Reviewed by Chris Dumez.
     7
     8        Add layout test coverage. Copy expectations from the existing sync-policy version of the test.
     9
     10        * http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
     11        * http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html: Added.
     12        * http/wpt/html/semantics/text-level-semantics/the-a-element/resources/a-download-404.html: Added.
     13        * platform/ios-wk2/http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
     14        * platform/mac-wk1/http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
     15        * platform/win/http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt: Added.
     16        * platform/wpe/TestExpectations:
     17
    1182018-03-05  Youenn Fablet  <youenn@apple.com>
    219

  • trunk/LayoutTests/platform/wpe/TestExpectations

    r229147 r229286  
    335335webkit.org/b/180648 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Timeout ]
    336336webkit.org/b/180648 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html [ Failure ]
     337webkit.org/b/180648 http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html [ Failure ]
    337338webkit.org/b/178576 imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html [ Failure ]
    338339webkit.org/b/178576 imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https.html [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r229209 r229286  
     12018-03-05  Ali Juma  <ajuma@chromium.org>
     2
     3        imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html times out with async policy delegates
     4        https://bugs.webkit.org/show_bug.cgi?id=183297
     5
     6        Reviewed by Chris Dumez.
     7
     8        When a FrameLoader's policy document loader is cleared after receiving a navigation policy decision
     9        to not continue loading, we still need to trigger a check for load completion, since this loader or
     10        an ancestor loader may have been in state isLoadingInAPISense only because of the existence of
     11        the just-cleared policy document loader. Without triggering this check, these loaders may never
     12        call WebFrameLoaderClient::dispatchDidFinishLoad.
     13
     14        Test: http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
     15
     16        * loader/FrameLoader.cpp:
     17        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
     18
    1192018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
    220

  • trunk/Source/WebCore/loader/FrameLoader.cpp

    r229209 r229286  
    31603160
    31613161        setPolicyDocumentLoader(nullptr);
     3162        checkLoadComplete();
    31623163
    31633164        // If the navigation request came from the back/forward menu, and we punt on it, we have the
Note: See TracChangeset for help on using the changeset viewer.