Changeset 229334 in webkit
- Timestamp:
- Mar 6, 2018 11:50:55 AM (6 years ago)
- Location:
- trunk/Source
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r229333 r229334 1 2018-03-06 Antoine Quint <graouts@apple.com> 2 3 [Web Animations] Add a new runtime flag to control whether CSS Animations and CSS Transitions should run using the Web Animations timeline 4 https://bugs.webkit.org/show_bug.cgi?id=183370 5 <rdar://problem/38180729> 6 7 Reviewed by Dean Jackson. 8 9 Before we start creating WebAnimation objects to perform CSS Animations and CSS Transitions, which will replace the existing codepath 10 involving CSSAnimationController and CompositeAnimation, we need a runtime flag that will allow all the new code to be turned off by 11 default while we bring this feature up. 12 13 * page/RuntimeEnabledFeatures.h: 14 (WebCore::RuntimeEnabledFeatures::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): 15 (WebCore::RuntimeEnabledFeatures::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled const): 16 1 17 2018-03-06 Daniel Bates <dabates@apple.com> 2 18 -
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
r228483 r229334 169 169 bool webAnimationsEnabled() const { return m_areWebAnimationsEnabled; } 170 170 171 void setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(bool areEnabled) { m_areCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled = areEnabled; } 172 bool cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled() const { return m_areCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled; } 173 171 174 #if ENABLE(WEBGL2) 172 175 void setWebGL2Enabled(bool isEnabled) { m_isWebGL2Enabled = isEnabled; } … … 332 335 333 336 bool m_areWebAnimationsEnabled { false }; 337 bool m_areCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled { false }; 334 338 335 339 #if ENABLE(WEBGL2) -
trunk/Source/WebKit/ChangeLog
r229320 r229334 1 2018-03-06 Antoine Quint <graouts@apple.com> 2 3 [Web Animations] Add a new runtime flag to control whether CSS Animations and CSS Transitions should run using the Web Animations timeline 4 https://bugs.webkit.org/show_bug.cgi?id=183370 5 <rdar://problem/38180729> 6 7 Reviewed by Dean Jackson. 8 9 Before we start creating WebAnimation objects to perform CSS Animations and CSS Transitions, which will replace the existing codepath 10 involving CSSAnimationController and CompositeAnimation, we need a runtime flag that will allow all the new code to be turned off by 11 default while we bring this feature up. 12 13 * Shared/WebPreferences.yaml: 14 * UIProcess/API/C/WKPreferences.cpp: 15 (WKPreferencesSetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): 16 (WKPreferencesGetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): 17 * UIProcess/API/C/WKPreferencesRefPrivate.h: 18 * UIProcess/API/Cocoa/WKPreferences.mm: 19 (-[WKPreferences _setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): 20 (-[WKPreferences _cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): 21 * UIProcess/API/Cocoa/WKPreferencesPrivate.h: 22 * WebProcess/InjectedBundle/InjectedBundle.cpp: 23 (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): 24 (WebKit::InjectedBundle::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): 25 * WebProcess/InjectedBundle/InjectedBundle.h: 26 1 27 2018-03-06 Ms2ger <Ms2ger@igalia.com> 2 28 -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r228486 r229334 99 99 webcoreName: animationTriggersEnabled 100 100 condition: ENABLE(CSS_ANIMATIONS_LEVEL_2) 101 102 CSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled: 103 type: bool 104 defaultValue: false 105 webcoreBinding: RuntimeEnabledFeatures 101 106 102 107 ForceFTPDirectoryListings: -
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
r228486 r229334 516 516 } 517 517 518 void WKPreferencesSetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef preferencesRef, bool flag) 519 { 520 toImpl(preferencesRef)->setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(flag); 521 } 522 523 bool WKPreferencesGetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef preferencesRef) 524 { 525 return toImpl(preferencesRef)->cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(); 526 } 527 518 528 void WKPreferencesSetNeedsSiteSpecificQuirks(WKPreferencesRef preferencesRef, bool flag) 519 529 { -
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
r228486 r229334 120 120 WK_EXPORT bool WKPreferencesGetWebAnimationsEnabled(WKPreferencesRef); 121 121 122 // Defaults to false 123 WK_EXPORT void WKPreferencesSetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef, bool flag); 124 WK_EXPORT bool WKPreferencesGetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef); 125 122 126 // Defaults to false. 123 127 WK_EXPORT void WKPreferencesSetNeedsSiteSpecificQuirks(WKPreferencesRef, bool); -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
r229294 r229334 973 973 } 974 974 975 - (void)_setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:(BOOL)enabled 976 { 977 _preferences->setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(enabled); 978 } 979 980 - (BOOL)_cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled 981 { 982 return _preferences->cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(); 983 } 984 975 985 - (void)_setStandardFontFamily:(NSString *)family 976 986 { -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
r229294 r229334 159 159 @property (nonatomic, setter=_setViewGestureDebuggingEnabled:) BOOL _viewGestureDebuggingEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA)); 160 160 @property (nonatomic, setter=_setCSSAnimationTriggersEnabled:) BOOL _cssAnimationTriggersEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA)); 161 @property (nonatomic, setter=_setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:) BOOL _cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA)); 161 162 @property (nonatomic, setter=_setStandardFontFamily:) NSString *_standardFontFamily WK_API_AVAILABLE(macosx(WK_MAC_TBA)); 162 163 @property (nonatomic, setter=_setNotificationsEnabled:) BOOL _notificationsEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA)); -
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
r227687 r229334 193 193 RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsEnabled(enabled); 194 194 195 if (preference == "WebKitCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled") 196 RuntimeEnabledFeatures::sharedFeatures().setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(enabled); 197 195 198 if (preference == "WebKitCacheAPIEnabled") 196 199 RuntimeEnabledFeatures::sharedFeatures().setCacheAPIEnabled(enabled); … … 615 618 } 616 619 620 void InjectedBundle::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(bool enabled) 621 { 622 RuntimeEnabledFeatures::sharedFeatures().setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(enabled); 623 } 624 617 625 } // namespace WebKit -
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h
r228502 r229334 152 152 void setCSSAnimationTriggersEnabled(bool); 153 153 void setWebAnimationsEnabled(bool); 154 void setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(bool); 154 155 void dispatchPendingLoadRequests(); 155 156
Note: See TracChangeset
for help on using the changeset viewer.