Changeset 229601 in webkit


Ignore:
Timestamp:
Mar 14, 2018 9:18:01 AM (6 years ago)
Author:
fred.wang@free.fr
Message:

Finish migration to MathML WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=183628

Patch by Frederic Wang <​fwang@igalia.com> on 2018-03-14
Reviewed by Manuel Rego Casasnovas.

In r225162, the MathML tests from the WPT repository were imported. They were intended to
replace the ones in imported/mathml-in-html5 but the migration was not fully possible. The
main issue was that many MathML tests use Web fonts to test the use of OpenType parameters
but document.fonts.ready is unreliable in WebKit (bug 174030). A workaround was implemented
in WPT ( ​https://github.com/w3c/web-platform-tests/pull/10025 ) so this commit finishes
the migration. We update the WPT MathML tests and now run them all, we remove
imported/mathml-in-html5 and the associated TestExpectations failures. Two cases unrelated to
font loading are still failing: One for the SuperscriptShiftUpCramped parameter (bug 156401)
and one for the RadicalDegreeBottomRaisePercent parameter (bug 183631).

LayoutTests/imported/w3c:

Reviewed by Manuel Rego Casasnovas.

  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1-expected.txt.

Also add the failure with RadicalDegreeBottomRaisePercent.

  • web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt.

Also add the failure for SuperscriptShiftUpCramped.

  • web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html: Import font loading workaround.
  • web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html: Import font loading workaround.
  • web-platform-tests/mathml/relations/css-styling/displaystyle-1.html: Import font loading workaround.
  • web-platform-tests/mathml/relations/css-styling/lengths-3.html: Import font loading workaround.
  • web-platform-tests/mathml/tools/utils/misc.py: Import update to Python 3.

(downloadWithProgressBar):

LayoutTests:

  • TestExpectations: Unskip MathML WPT tests.
  • imported/mathml-in-html5/LICENSE: Removed.
  • imported/mathml-in-html5/README.md: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html: Removed.
  • imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html: Removed.
  • platform/mac-wk2/TestExpectations: Remove the expectation.
  • platform/win/TestExpectations: Remove the expectation.
Location:
trunk/LayoutTests
Files:
1 deleted
18 edited
8 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r229597 r229601  
     12018-03-14  Frederic Wang  <fwang@igalia.com>
     2
     3        Finish migration to MathML WPT tests
     4        https://bugs.webkit.org/show_bug.cgi?id=183628
     5
     6        Reviewed by Manuel Rego Casasnovas.
     7
     8        In r225162, the MathML tests from the WPT repository were imported. They were intended to
     9        replace the ones in imported/mathml-in-html5 but the migration was not fully possible. The
     10        main issue was that many MathML tests use Web fonts to test the use of OpenType parameters
     11        but document.fonts.ready is unreliable in WebKit (bug 174030). A workaround was implemented
     12        in WPT ( https://github.com/w3c/web-platform-tests/pull/10025 ) so this commit finishes
     13        the migration. We update the WPT MathML tests and now run them all, we remove
     14        imported/mathml-in-html5 and the associated TestExpectations failures. Two cases unrelated to
     15        font loading are still failing: One for the SuperscriptShiftUpCramped parameter (bug 156401)
     16        and one for the RadicalDegreeBottomRaisePercent parameter (bug 183631).
     17
     18        * TestExpectations: Unskip MathML WPT tests.
     19        * imported/mathml-in-html5/LICENSE: Removed.
     20        * imported/mathml-in-html5/README.md: Removed.
     21        * imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html: Removed.
     22        * imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html: Removed.
     23        * imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html: Removed.
     24        * imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html: Removed.
     25        * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html: Removed.
     26        * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html: Removed.
     27        * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html: Removed.
     28        * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html: Removed.
     29        * platform/mac-wk2/TestExpectations: Remove the expectation.
     30        * platform/win/TestExpectations: Remove the expectation.
     31
    1322018-03-13  John Wilander  <wilander@apple.com>
    233

  • trunk/LayoutTests/TestExpectations

    r229590 r229601  
    591591imported/w3c/web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html [ Pass Failure ]
    592592imported/w3c/web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub.html [ Pass Failure ]
    593 
    594 # These MathML WPT tests are skipped because they are executed before Web fonts are available.
    595 # For now, tweaked versions remain in LayoutTests/imported/mathml-in-html5/.
    596 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html [ Skip ]
    597 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html [ Skip ]
    598 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html [ Skip ]
    599 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html [ Skip ]
    600 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html [ Skip ]
    601 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html [ Skip ]
    602 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html [ Skip ]
    603 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html [ Skip ]
    604593
    605594# These MathML WPT tests fail.

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r229590 r229601  
     12018-03-14  Frederic Wang  <fwang@igalia.com>
     2
     3        Finish migration to MathML WPT tests
     4        https://bugs.webkit.org/show_bug.cgi?id=183628
     5
     6        Reviewed by Manuel Rego Casasnovas.
     7
     8        In r225162, the MathML tests from the WPT repository were imported. They were intended to
     9        replace the ones in imported/mathml-in-html5 but the migration was not fully possible. The
     10        main issue was that many MathML tests use Web fonts to test the use of OpenType parameters
     11        but document.fonts.ready is unreliable in WebKit (bug 174030). A workaround was implemented
     12        in WPT ( https://github.com/w3c/web-platform-tests/pull/10025 ) so this commit finishes
     13        the migration. We update the WPT MathML tests and now run them all, we remove
     14        imported/mathml-in-html5 and the associated TestExpectations failures. Two cases unrelated to
     15        font loading are still failing: One for the SuperscriptShiftUpCramped parameter (bug 156401)
     16        and one for the RadicalDegreeBottomRaisePercent parameter (bug 183631).
     17
     18        Reviewed by Manuel Rego Casasnovas.
     19
     20        * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt.
     21        * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html: Import font loading workaround.
     22        * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt.
     23        * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html: Import font loading workaround.
     24        * web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html: Import font loading workaround.
     25        * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1-expected.txt.
     26        Also add the failure with RadicalDegreeBottomRaisePercent.
     27        * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html: Import font loading workaround.
     28        * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt.
     29        Also add the failure for SuperscriptShiftUpCramped.
     30        * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html: Import font loading workaround.
     31        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt.
     32        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html: Import font loading workaround.
     33        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt.
     34        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html: Import font loading workaround.
     35        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt.
     36        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html: Import font loading workaround.
     37        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt.
     38        * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html: Import font loading workaround.
     39        * web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html: Import font loading workaround.
     40        * web-platform-tests/mathml/relations/css-styling/displaystyle-1.html: Import font loading workaround.
     41        * web-platform-tests/mathml/relations/css-styling/lengths-3.html: Import font loading workaround.
     42        * web-platform-tests/mathml/tools/utils/misc.py: Import update to Python 3.
     43        (downloadWithProgressBar):
     44
    1452018-03-13  Youenn Fablet  <youenn@apple.com>
    246

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html

    r225162 r229601  
    6363  setup({ explicit_done: true });
    6464  window.addEventListener("load", function() {
    65     document.fonts.ready.then(runTests);
     65    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     66    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    6667  });
    6768

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html

    r225162 r229601  
    5151  setup({ explicit_done: true });
    5252  window.addEventListener("load", function() {
    53     document.fonts.ready.then(runTests);
     53    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     54    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    5455  });
    5556

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html

    r225162 r229601  
    2727  setup({ explicit_done: true });
    2828  window.addEventListener("load", function() {
    29     document.fonts.ready.then(runTests);
     29    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     30    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    3031  });
    3132

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt

    r229600 r229601  
    11
    2 PASS RadicalDegreeBottomRaisePercent
     2FAIL RadicalDegreeBottomRaisePercent assert_approx_equals: mroot: vertical position of index expected 27.5 +/- 1 but got 25
    33PASS RadicalDisplayStyleVerticalGap
    44PASS RadicalExtraAscender

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html

    r225162 r229601  
    5151  setup({ explicit_done: true });
    5252  window.addEventListener("load", function() {
    53     document.fonts.ready.then(runTests);
     53    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     54    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    5455  });
    5556

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt

    r229600 r229601  
    1515PASS SpaceAfterScript
    1616PASS SuperscriptShiftUp
     17FAIL SuperscriptShiftUpCramped assert_approx_equals: msup: Superscript shift expected 50 +/- 1 but got 20
    1718PASS SubscriptShiftDown
    1819PASS SubSuperscriptGapMin

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html

    r225162 r229601  
    6363  setup({ explicit_done: true });
    6464  window.addEventListener("load", function() {
    65     document.fonts.ready.then(runTests);
     65    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     66    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    6667  });
    6768

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html

    r225162 r229601  
    3939  setup({ explicit_done: true });
    4040  window.addEventListener("load", function() {
    41     document.fonts.ready.then(runTests);
     41    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     42    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    4243  });
    4344

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html

    r225162 r229601  
    3939  setup({ explicit_done: true });
    4040  window.addEventListener("load", function() {
    41     document.fonts.ready.then(runTests);
     41    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     42    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    4243  });
    4344

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html

    r225162 r229601  
    4242  setup({ explicit_done: true });
    4343  window.addEventListener("load", function() {
    44     document.fonts.ready.then(runTests);
     44    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     45    requestAnimationFrame(() => {   document.fonts.ready.then(runTests); });
    4546  });
    4647

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html

    r225162 r229601  
    4242  setup({ explicit_done: true });
    4343  window.addEventListener("load", function() {
    44     document.fonts.ready.then(runTests);
     44    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     45    requestAnimationFrame(() => {   document.fonts.ready.then(runTests); });
    4546  });
    4647

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html

    r225162 r229601  
    2727  setup({ explicit_done: true });
    2828  window.addEventListener("load", function() {
    29     document.fonts.ready.then(runTests);
     29    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     30    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    3031  });
    3132

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-1.html

    r225162 r229601  
    3333
    3434  window.addEventListener("load", function() {
    35     document.fonts.ready.then(runTests);
     35    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     36    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    3637  });
    3738

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-3.html

    r225162 r229601  
    2727  setup({ explicit_done: true });
    2828  window.addEventListener("load", function() {
    29     document.fonts.ready.then(runTests);
     29    // Delay the check to workaround WebKit's bug https://webkit.org/b/174030.
     30    requestAnimationFrame(() => { document.fonts.ready.then(runTests); });
    3031  });
    3132

  • trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/misc.py

    r225162 r229601  
    22import os
    33import progressbar
    4 import urllib2
     4try:
     5    from urllib.request import urlopen
     6except ImportError:
     7    from urllib2 import urlopen
    58
    69MathMLAssociationCopyright = "Copyright (c) 2016 MathML Association"
    … …  
    1417        return fileName
    1518
    16     request = urllib2.urlopen(url)
     19    request = urlopen(url)
    1720    totalSize = int(request.info().getheader('Content-Length').strip())
    1821    bar = progressbar.ProgressBar(maxval=totalSize).start()
    … …  
    2124    downloaded = 0
    2225    print("Downloading %s" % url)
    23     os.umask(0002)
     26    os.umask(0o002)
    2427    with open(fileName, 'wb') as fp:
    2528        while True:

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r229597 r229601  
    655655webkit.org/b/165352 fast/dom/Window/window-resize-contents.html [ Pass Timeout ]
    656656
    657 webkit.org/b/165392 [ ElCapitan Release ] imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html [ Pass Failure ]
    658 
    659657webkit.org/b/167653 http/tests/contentextensions/block-everything-unless-domain.html [ Pass Timeout ]
    660658

  • trunk/LayoutTests/platform/win/TestExpectations

    r229582 r229601  
    38953895# The following tests are failing only on ews203.
    38963896webkit.org/b/182694 fast/text/tatechuyoko.html [ Failure ]
    3897 webkit.org/b/182694 imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html [ Failure ]
    38983897webkit.org/b/182694 fast/css/fontloader-svg-select.svg [ Crash ]
    38993898webkit.org/b/182694 fast/dom/crash-moving-subtree-between-documents.html [ Crash ]
Note: See TracChangeset for help on using the changeset viewer.