Changeset 229601 in webkit
- Timestamp:
- Mar 14, 2018 9:18:01 AM (6 years ago)
- Location:
- trunk/LayoutTests
- Files:
-
- 1 deleted
- 18 edited
- 8 copied
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r229597 r229601 1 2018-03-14 Frederic Wang <fwang@igalia.com> 2 3 Finish migration to MathML WPT tests 4 https://bugs.webkit.org/show_bug.cgi?id=183628 5 6 Reviewed by Manuel Rego Casasnovas. 7 8 In r225162, the MathML tests from the WPT repository were imported. They were intended to 9 replace the ones in imported/mathml-in-html5 but the migration was not fully possible. The 10 main issue was that many MathML tests use Web fonts to test the use of OpenType parameters 11 but document.fonts.ready is unreliable in WebKit (bug 174030). A workaround was implemented 12 in WPT ( https://github.com/w3c/web-platform-tests/pull/10025 ) so this commit finishes 13 the migration. We update the WPT MathML tests and now run them all, we remove 14 imported/mathml-in-html5 and the associated TestExpectations failures. Two cases unrelated to 15 font loading are still failing: One for the SuperscriptShiftUpCramped parameter (bug 156401) 16 and one for the RadicalDegreeBottomRaisePercent parameter (bug 183631). 17 18 * TestExpectations: Unskip MathML WPT tests. 19 * imported/mathml-in-html5/LICENSE: Removed. 20 * imported/mathml-in-html5/README.md: Removed. 21 * imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html: Removed. 22 * imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html: Removed. 23 * imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html: Removed. 24 * imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html: Removed. 25 * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html: Removed. 26 * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html: Removed. 27 * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html: Removed. 28 * imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html: Removed. 29 * platform/mac-wk2/TestExpectations: Remove the expectation. 30 * platform/win/TestExpectations: Remove the expectation. 31 1 32 2018-03-13 John Wilander <wilander@apple.com> 2 33 -
trunk/LayoutTests/TestExpectations
r229590 r229601 591 591 imported/w3c/web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html [ Pass Failure ] 592 592 imported/w3c/web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub.html [ Pass Failure ] 593 594 # These MathML WPT tests are skipped because they are executed before Web fonts are available.595 # For now, tweaked versions remain in LayoutTests/imported/mathml-in-html5/.596 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html [ Skip ]597 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html [ Skip ]598 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html [ Skip ]599 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html [ Skip ]600 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html [ Skip ]601 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html [ Skip ]602 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html [ Skip ]603 webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html [ Skip ]604 593 605 594 # These MathML WPT tests fail. -
trunk/LayoutTests/imported/w3c/ChangeLog
r229590 r229601 1 2018-03-14 Frederic Wang <fwang@igalia.com> 2 3 Finish migration to MathML WPT tests 4 https://bugs.webkit.org/show_bug.cgi?id=183628 5 6 Reviewed by Manuel Rego Casasnovas. 7 8 In r225162, the MathML tests from the WPT repository were imported. They were intended to 9 replace the ones in imported/mathml-in-html5 but the migration was not fully possible. The 10 main issue was that many MathML tests use Web fonts to test the use of OpenType parameters 11 but document.fonts.ready is unreliable in WebKit (bug 174030). A workaround was implemented 12 in WPT ( https://github.com/w3c/web-platform-tests/pull/10025 ) so this commit finishes 13 the migration. We update the WPT MathML tests and now run them all, we remove 14 imported/mathml-in-html5 and the associated TestExpectations failures. Two cases unrelated to 15 font loading are still failing: One for the SuperscriptShiftUpCramped parameter (bug 156401) 16 and one for the RadicalDegreeBottomRaisePercent parameter (bug 183631). 17 18 Reviewed by Manuel Rego Casasnovas. 19 20 * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt. 21 * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html: Import font loading workaround. 22 * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt. 23 * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html: Import font loading workaround. 24 * web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html: Import font loading workaround. 25 * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1-expected.txt. 26 Also add the failure with RadicalDegreeBottomRaisePercent. 27 * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html: Import font loading workaround. 28 * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt. 29 Also add the failure for SuperscriptShiftUpCramped. 30 * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html: Import font loading workaround. 31 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt. 32 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html: Import font loading workaround. 33 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt. 34 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html: Import font loading workaround. 35 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt. 36 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html: Import font loading workaround. 37 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt. 38 * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html: Import font loading workaround. 39 * web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html: Import font loading workaround. 40 * web-platform-tests/mathml/relations/css-styling/displaystyle-1.html: Import font loading workaround. 41 * web-platform-tests/mathml/relations/css-styling/lengths-3.html: Import font loading workaround. 42 * web-platform-tests/mathml/tools/utils/misc.py: Import update to Python 3. 43 (downloadWithProgressBar): 44 1 45 2018-03-13 Youenn Fablet <youenn@apple.com> 2 46 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html
r225162 r229601 63 63 setup({ explicit_done: true }); 64 64 window.addEventListener("load", function() { 65 document.fonts.ready.then(runTests); 65 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 66 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 66 67 }); 67 68 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html
r225162 r229601 51 51 setup({ explicit_done: true }); 52 52 window.addEventListener("load", function() { 53 document.fonts.ready.then(runTests); 53 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 54 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 54 55 }); 55 56 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html
r225162 r229601 27 27 setup({ explicit_done: true }); 28 28 window.addEventListener("load", function() { 29 document.fonts.ready.then(runTests); 29 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 30 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 30 31 }); 31 32 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt
r229600 r229601 1 1 2 PASS RadicalDegreeBottomRaisePercent 2 FAIL RadicalDegreeBottomRaisePercent assert_approx_equals: mroot: vertical position of index expected 27.5 +/- 1 but got 25 3 3 PASS RadicalDisplayStyleVerticalGap 4 4 PASS RadicalExtraAscender -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html
r225162 r229601 51 51 setup({ explicit_done: true }); 52 52 window.addEventListener("load", function() { 53 document.fonts.ready.then(runTests); 53 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 54 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 54 55 }); 55 56 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt
r229600 r229601 15 15 PASS SpaceAfterScript 16 16 PASS SuperscriptShiftUp 17 FAIL SuperscriptShiftUpCramped assert_approx_equals: msup: Superscript shift expected 50 +/- 1 but got 20 17 18 PASS SubscriptShiftDown 18 19 PASS SubSuperscriptGapMin -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html
r225162 r229601 63 63 setup({ explicit_done: true }); 64 64 window.addEventListener("load", function() { 65 document.fonts.ready.then(runTests); 65 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 66 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 66 67 }); 67 68 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html
r225162 r229601 39 39 setup({ explicit_done: true }); 40 40 window.addEventListener("load", function() { 41 document.fonts.ready.then(runTests); 41 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 42 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 42 43 }); 43 44 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html
r225162 r229601 39 39 setup({ explicit_done: true }); 40 40 window.addEventListener("load", function() { 41 document.fonts.ready.then(runTests); 41 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 42 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 42 43 }); 43 44 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html
r225162 r229601 42 42 setup({ explicit_done: true }); 43 43 window.addEventListener("load", function() { 44 document.fonts.ready.then(runTests); 44 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 45 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 45 46 }); 46 47 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html
r225162 r229601 42 42 setup({ explicit_done: true }); 43 43 window.addEventListener("load", function() { 44 document.fonts.ready.then(runTests); 44 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 45 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 45 46 }); 46 47 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html
r225162 r229601 27 27 setup({ explicit_done: true }); 28 28 window.addEventListener("load", function() { 29 document.fonts.ready.then(runTests); 29 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 30 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 30 31 }); 31 32 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-1.html
r225162 r229601 33 33 34 34 window.addEventListener("load", function() { 35 document.fonts.ready.then(runTests); 35 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 36 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 36 37 }); 37 38 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-3.html
r225162 r229601 27 27 setup({ explicit_done: true }); 28 28 window.addEventListener("load", function() { 29 document.fonts.ready.then(runTests); 29 // Delay the check to workaround WebKit's bug https://webkit.org/b/174030. 30 requestAnimationFrame(() => { document.fonts.ready.then(runTests); }); 30 31 }); 31 32 -
trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/misc.py
r225162 r229601 2 2 import os 3 3 import progressbar 4 import urllib2 4 try: 5 from urllib.request import urlopen 6 except ImportError: 7 from urllib2 import urlopen 5 8 6 9 MathMLAssociationCopyright = "Copyright (c) 2016 MathML Association" … … 14 17 return fileName 15 18 16 request = url lib2.urlopen(url)19 request = urlopen(url) 17 20 totalSize = int(request.info().getheader('Content-Length').strip()) 18 21 bar = progressbar.ProgressBar(maxval=totalSize).start() … … 21 24 downloaded = 0 22 25 print("Downloading %s" % url) 23 os.umask(0 002)26 os.umask(0o002) 24 27 with open(fileName, 'wb') as fp: 25 28 while True: -
trunk/LayoutTests/platform/mac-wk2/TestExpectations
r229597 r229601 655 655 webkit.org/b/165352 fast/dom/Window/window-resize-contents.html [ Pass Timeout ] 656 656 657 webkit.org/b/165392 [ ElCapitan Release ] imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html [ Pass Failure ]658 659 657 webkit.org/b/167653 http/tests/contentextensions/block-everything-unless-domain.html [ Pass Timeout ] 660 658 -
trunk/LayoutTests/platform/win/TestExpectations
r229582 r229601 3895 3895 # The following tests are failing only on ews203. 3896 3896 webkit.org/b/182694 fast/text/tatechuyoko.html [ Failure ] 3897 webkit.org/b/182694 imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html [ Failure ]3898 3897 webkit.org/b/182694 fast/css/fontloader-svg-select.svg [ Crash ] 3899 3898 webkit.org/b/182694 fast/dom/crash-moving-subtree-between-documents.html [ Crash ]
Note: See TracChangeset
for help on using the changeset viewer.