Changeset 229841 in webkit

Timestamp:

Mar 21, 2018 6:49:27 PM (6 years ago)

Author:

Chris Dumez

Message:

Regression(r229831): ProcessSwap.Basic API test is crashing
​https://bugs.webkit.org/show_bug.cgi?id=183884

Reviewed by Brady Eidson.

This code should only be called for navigation policy decisions.
It used to work without this check because of an early return, which
was dropped in r229831.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-03-21  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r229831): ProcessSwap.Basic API test is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=183884
+
+        Reviewed by Brady Eidson.
+
+        This code should only be called for navigation policy decisions.
+        It used to work without this check because of an early return, which
+        was dropped in r229831.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::receivedPolicyDecision):
+
 2018-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -2370 +2370 @@
 
     auto* activePolicyListener = frame.activePolicyListenerProxy();
-    if (activePolicyListener) {
+    if (activePolicyListener && activePolicyListener->policyListenerType() == PolicyListenerType::NavigationAction) {
         ASSERT(activePolicyListener->listenerID() == listenerID);