Changeset 229846 in webkit

Timestamp:

Mar 21, 2018 11:48:43 PM (6 years ago)

Author:

fred.wang@free.fr

Message:

Unreviewed, update comment added in r229801.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-03-21

• WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::didFindString): Remove "On Mobile" and mention bug 183889.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/FindControllerIOS.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-03-21  Frederic Wang  <fwang@igalia.com>
+
+        Unreviewed, update comment added in r229801.
+
+        * WebProcess/WebPage/ios/FindControllerIOS.mm:
+        (WebKit::FindController::didFindString): Remove "On Mobile" and mention bug 183889.
+
 2018-03-21  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm

@@ -161 +161 @@
     // Scrolling the main frame is handled by the SmartMagnificationController class but we still
     // need to consider overflow nodes and subframes here.
-    // On Mobile, many sites have overlay headers or footers that may overlap with the highlighted
-    // text, so we reveal the text at the center of the viewport. See https://webkit.org/b/183658
+    // Many sites have overlay headers or footers that may overlap with the highlighted
+    // text, so we reveal the text at the center of the viewport.
+    // FIXME: Find a better way to estimate the obscured area (https://webkit.org/b/183889).
     frame.selection().revealSelection(SelectionRevealMode::RevealUpToMainFrame, ScrollAlignment::alignCenterAlways, WebCore::DoNotRevealExtent);
 }