Changeset 229867 in webkit

Timestamp:

Mar 22, 2018 2:59:41 PM (6 years ago)

Author:

Alan Bujtas

Message:

[Simple line layout] Text with letter spacing is not positioned properly.
​https://bugs.webkit.org/show_bug.cgi?id=183079
<rdar://problem/38762569>

Reviewed by Antti Koivisto.

Source/WebCore:

We need to recompute RenderText::m_canUseSimplifiedTextMeasuring when the font cascade changes
since we might not be able to use the fast path anymore.

Test: fast/text/simple-line-layout-dynamic-letter-word-spacing.html

• rendering/RenderText.cpp:

(WebCore::RenderText::styleDidChange):

LayoutTests:

• fast/text/simple-line-layout-dynamic-letter-word-spacing-expected.html: Added.
• fast/text/simple-line-layout-dynamic-letter-word-spacing.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/simple-line-layout-dynamic-letter-word-spacing-expected.html (added)
• LayoutTests/fast/text/simple-line-layout-dynamic-letter-word-spacing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderText.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-03-22  Zalan Bujtas  <zalan@apple.com>
+
+        [Simple line layout] Text with letter spacing is not positioned properly.
+        https://bugs.webkit.org/show_bug.cgi?id=183079
+        <rdar://problem/38762569>
+
+        Reviewed by Antti Koivisto.
+
+        * fast/text/simple-line-layout-dynamic-letter-word-spacing-expected.html: Added.
+        * fast/text/simple-line-layout-dynamic-letter-word-spacing.html: Added.
+
 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-03-22  Zalan Bujtas  <zalan@apple.com>
+
+        [Simple line layout] Text with letter spacing is not positioned properly.
+        https://bugs.webkit.org/show_bug.cgi?id=183079
+        <rdar://problem/38762569>
+
+        Reviewed by Antti Koivisto.
+
+        We need to recompute RenderText::m_canUseSimplifiedTextMeasuring when the font cascade changes
+        since we might not be able to use the fast path anymore.
+
+        Test: fast/text/simple-line-layout-dynamic-letter-word-spacing.html
+
+        * rendering/RenderText.cpp:
+        (WebCore::RenderText::styleDidChange):
+
 2018-03-21  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/rendering/RenderText.cpp

@@ -264 +264 @@
         m_useBackslashAsYenSymbol = computeUseBackslashAsYenSymbol();
         needsResetText = m_useBackslashAsYenSymbol;
-        // It should really be computed in the c'tor, but during construction we don't have parent yet -and RenderText style == parent()->style()
-        m_canUseSimplifiedTextMeasuring = computeCanUseSimplifiedTextMeasuring();
     } else if (oldStyle->fontCascade().useBackslashAsYenSymbol() != newStyle.fontCascade().useBackslashAsYenSymbol()) {
         m_useBackslashAsYenSymbol = computeUseBackslashAsYenSymbol();
         needsResetText = true;
     }
+
+    if (!oldStyle || oldStyle->fontCascade() != newStyle.fontCascade())
+        m_canUseSimplifiedTextMeasuring = computeCanUseSimplifiedTextMeasuring();
 
     ETextTransform oldTransform = oldStyle ? oldStyle->textTransform() : TTNONE;