Changeset 230167 in webkit

Timestamp:

Apr 2, 2018 11:34:35 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

webkitpy: Use current environment value for GST_DEBUG(_FILE) and DOT_DIR env vars
​https://bugs.webkit.org/show_bug.cgi?id=184036

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-04-02
Reviewed by Philippe Normand.

Those variables are for debug purpose and should not change the behaviour
itself, and developers expect them to have effect.

• Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/gtk.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-04-02  Thibault Saunier  <tsaunier@igalia.com>
+
+        webkitpy: Use current environment value for GST_DEBUG(_FILE) and DOT_DIR env vars
+        https://bugs.webkit.org/show_bug.cgi?id=184036
+
+        Reviewed by Philippe Normand.
+
+        Those variables are for debug purpose and should not change the behaviour
+        itself, and developers expect them to have effect.
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.setup_environ_for_server):
+
 2018-04-02  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/gtk.py

@@ -123 +123 @@
         environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('lib', 'plugins')
         self._copy_value_from_environ_if_set(environment, 'WEBKIT_OUTPUTDIR')
+        self._copy_value_from_environ_if_set(environment, 'GST_DEBUG')
+        self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_DUMP_DOT_DIR')
+        self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_FILE')
 
         # Configure the software libgl renderer if jhbuild ready and we test inside a virtualized window system