Changeset 230307 in webkit
- Timestamp:
- Apr 5, 2018 10:43:35 AM (6 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r230298 r230307 1 2018-04-05 Youenn Fablet <youenn@apple.com> 2 3 WebRTC data channel only applications require capture permissions for direct connections 4 https://bugs.webkit.org/show_bug.cgi?id=174500 5 <rdar://problem/34134281> 6 7 Unreviewed. 8 Changed the code to suppress: "error: unused variable 'error' [-Werror,-Wunused-variable]" 9 Added some logging to this error case as a side bonus. 10 11 * NetworkProcess/webrtc/NetworkMDNSRegister.cpp: 12 (WebKit::NetworkMDNSRegister::registerMDNSName): 13 1 14 2018-04-05 Carlos Garcia Campos <cgarcia@igalia.com> 2 15 -
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp
r230290 r230307 98 98 auto iterator = m_services.find(documentIdentifier); 99 99 if (iterator == m_services.end()) { 100 if (auto error = DNSServiceCreateConnection(&service)) { 100 auto error = DNSServiceCreateConnection(&service); 101 if (error) { 102 RELEASE_LOG_IF_ALLOWED(sessionID, "registerMDNSName DNSServiceCreateConnection error %d", error); 101 103 m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, makeUnexpected(MDNSRegisterError::DNSSD) }, 0); 102 104 return; 103 105 } 104 if (auto error = DNSServiceSetDispatchQueue(service, dispatch_get_main_queue())) { 106 error = DNSServiceSetDispatchQueue(service, dispatch_get_main_queue()); 107 if (error) { 108 RELEASE_LOG_IF_ALLOWED(sessionID, "registerMDNSName DNSServiceCreateConnection error %d", error); 105 109 m_connection.connection().send(Messages::WebMDNSRegister::FinishedRegisteringMDNSName { requestIdentifier, makeUnexpected(MDNSRegisterError::DNSSD) }, 0); 106 110 return;
Note: See TracChangeset
for help on using the changeset viewer.