Changeset 230481 in webkit

Timestamp:

Apr 10, 2018 9:26:42 AM (6 years ago)

Author:

magomez@igalia.com

Message:

[GTK][WPE] Race condition when destroying webprocesses
​https://bugs.webkit.org/show_bug.cgi?id=184445

Reviewed by Carlos Garcia Campos.

Ensure that the WebProcess is properly closing its pages when it's exiting because
the UIProcess has invalidated the IPC connection.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didClose):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebProcess.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-10  Miguel Gomez  <magomez@igalia.com>
+
+        [GTK][WPE] Race condition when destroying webprocesses
+        https://bugs.webkit.org/show_bug.cgi?id=184445
+
+        Reviewed by Carlos Garcia Campos.
+
+        Ensure that the WebProcess is properly closing its pages when it's exiting because
+        the UIProcess has invalidated the IPC connection.
+
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::didClose):
+
 2018-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/WebProcess/WebProcess.cpp

@@ -687 +687 @@
 void WebProcess::didClose(IPC::Connection&)
 {
-#ifndef NDEBUG
+#if !defined(NDEBUG) || PLATFORM(GTK) || PLATFORM(WPE)
     for (auto& page : copyToVector(m_pageMap.values()))
         page->close();
-
+#endif
+
+#ifndef NDEBUG
     GCController::singleton().garbageCollectSoon();
     FontCache::singleton().invalidate();