Changeset 230559 in webkit

Timestamp:

Apr 12, 2018 12:01:57 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Switch to use always complex text code path
​https://bugs.webkit.org/show_bug.cgi?id=183285

Reviewed by Michael Catanzaro.

Source/WebKit:

Now that we have branched for 2.20, it's a good time to try using complex text path always. We can simply force
it for GTK+ port and see how it works for the whole release cycle and if we don't notice any issues or
performance regressions we release 2.22 with complex text path forced. A debug env variable is added to switch
back to auto without having to recompile. After 2.22 is released we can make a final decision and remove the env
variable.

• UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess): Force complex text code path unless
WEBKIT_FORCE_COMPLEX_TEXT is present and set to 0.

Tools:

Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.

• WebKitTestRunner/gtk/main.cpp:

(main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/gtk/main.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Switch to use always complex text code path
+        https://bugs.webkit.org/show_bug.cgi?id=183285
+
+        Reviewed by Michael Catanzaro.
+
+        Now that we have branched for 2.20, it's a good time to try using complex text path always. We can simply force
+        it for GTK+ port and see how it works for the whole release cycle and if we don't notice any issues or
+        performance regressions we release 2.22 with complex text path forced. A debug env variable is added to switch
+        back to auto without having to recompile. After 2.22 is released we can make a final decision and remove the env
+        variable.
+
+        * UIProcess/gtk/WebProcessPoolGtk.cpp:
+        (WebKit::WebProcessPool::platformInitializeWebProcess): Force complex text code path unless
+        WEBKIT_FORCE_COMPLEX_TEXT is present and set to 0.
+
 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp

@@ -93 +93 @@
     parameters.proxySettings = m_networkProxySettings;
 
+    parameters.shouldAlwaysUseComplexTextCodePath = true;
+    const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT");
+    if (forceComplexText && !strcmp(forceComplexText, "0"))
+        parameters.shouldAlwaysUseComplexTextCodePath = m_alwaysUsesComplexTextCodePath;
+
 #if USE(GSTREAMER)
     parameters.gstreamerOptions = WebCore::extractGStreamerOptionsFromCommandLine();

trunk/Tools/ChangeLog

@@ +1 @@
+2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Switch to use always complex text code path
+        https://bugs.webkit.org/show_bug.cgi?id=183285
+
+        Reviewed by Michael Catanzaro.
+
+        Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
+
+        * WebKitTestRunner/gtk/main.cpp:
+        (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
+
 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/WebKitTestRunner/gtk/main.cpp

@@ -33 +33 @@
 int main(int argc, char** argv)
 {
+    g_setenv("WEBKIT_FORCE_COMPLEX_TEXT", "0", FALSE);
+
     gtk_init(&argc, &argv);