Changeset 230584 in webkit

Timestamp:

Apr 12, 2018 11:01:58 AM (6 years ago)

Author:

aboya@igalia.com

Message:

[MSE] Add isValid() assertions on PlatformTimeRanges::add() range ends
​https://bugs.webkit.org/show_bug.cgi?id=180253

Right now it's checked that start <= end but it's not checked that
neither of them is undefined.

When this happens, the bug can be hard to track down.

The assertion is not enabled for Mac because there is currently a test
that is hitting it.

Reviewed by Jer Noble.

• platform/graphics/PlatformTimeRanges.cpp:

(WebCore::PlatformTimeRanges::add):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/PlatformTimeRanges.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-12  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE] Add isValid() assertions on PlatformTimeRanges::add() range ends
+        https://bugs.webkit.org/show_bug.cgi?id=180253
+
+        Right now it's checked that start <= end but it's not checked that
+        neither of them is undefined.
+
+        When this happens, the bug can be hard to track down.
+
+        The assertion is not enabled for Mac because there is currently a test
+        that is hitting it.
+
+        Reviewed by Jer Noble.
+
+        * platform/graphics/PlatformTimeRanges.cpp:
+        (WebCore::PlatformTimeRanges::add):
+
 2018-04-12  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/graphics/PlatformTimeRanges.cpp

@@ -135 +135 @@
 void PlatformTimeRanges::add(const MediaTime& start, const MediaTime& end)
 {
+#if !PLATFORM(MAC) // https://bugs.webkit.org/show_bug.cgi?id=180253
+    ASSERT(start.isValid());
+    ASSERT(end.isValid());
+#endif
     ASSERT(start <= end);
+
     unsigned overlappingArcIndex;
     Range addedRange(start, end);