Changeset 230674 in webkit

Timestamp:

Apr 16, 2018 11:33:13 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
​https://bugs.webkit.org/show_bug.cgi?id=184652

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-04-16
Reviewed by Philippe Normand.

In the constructor we should mark selected streams based on the default values from GstStream,
if the user changes them, they will be updated as required later on.

No new tests are added as we already have a few ones that are currently disabled in
the mediastream testsuite. This patch is part of the work to enable them.

• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):

• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp (modified) (1 diff)
• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-16  Thibault Saunier  <tsaunier@igalia.com>
+
+        [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
+        https://bugs.webkit.org/show_bug.cgi?id=184652
+
+        Reviewed by Philippe Normand.
+
+        In the constructor we should mark selected streams based on the default values from GstStream,
+        if the user changes them, they will be updated as required later on.
+
+        No new tests are added as we already have a few ones that are currently disabled in
+        the mediastream testsuite. This patch is part of the work to enable them.
+
+        * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
+        (WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
+        * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
+        (WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
+
 2018-04-16  Thibault Saunier  <tsaunier@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp

@@ -50 +50 @@
 {
     m_id = gst_stream_get_stream_id(stream.get());
+    setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
     notifyTrackOfActiveChanged();
 }

trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp

@@ -50 +50 @@
 {
     m_id = gst_stream_get_stream_id(stream.get());
+    setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
     notifyTrackOfActiveChanged();
 }