Changeset 230786 in webkit


Ignore:
Timestamp:
Apr 18, 2018 3:01:27 PM (6 years ago)
Author:
Antti Koivisto
Message:

:active pseudo class doesn't deactivate when using pressure sensitive trackpad
https://bugs.webkit.org/show_bug.cgi?id=181680

Reviewed by Beth Dakin.

Trackpad sends a mouse force event with force of zero after mouse up event. This causes the element under cursor
activate again.

Even a fake event test doesn't appear to be currently possible as TestRunner crashes if you try to send mouseForceChanged.
All the tests using it are skipped.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseForceEvent):

Don't add HitTestRequest::Active if the force of the force event is zero.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r230785 r230786  
     12018-04-18  Antti Koivisto  <antti@apple.com>
     2
     3        :active pseudo class doesn't deactivate when using pressure sensitive trackpad
     4        https://bugs.webkit.org/show_bug.cgi?id=181680
     5
     6        Reviewed by Beth Dakin.
     7
     8        Trackpad sends a mouse force event with force of zero after mouse up event. This causes the element under cursor
     9        activate again.
     10
     11        Even a fake event test doesn't appear to be currently possible as TestRunner crashes if you try to send mouseForceChanged.
     12        All the tests using it are skipped.
     13
     14        * page/EventHandler.cpp:
     15        (WebCore::EventHandler::handleMouseForceEvent):
     16
     17        Don't add HitTestRequest::Active if the force of the force event is zero.
     18
    1192018-04-18  Megan Gardner  <megan_gardner@apple.com>
    220
  • trunk/Source/WebCore/page/EventHandler.cpp

    r230211 r230786  
    21272127    setLastKnownMousePosition(event);
    21282128
    2129     HitTestRequest::HitTestRequestType hitType = HitTestRequest::DisallowUserAgentShadowContent | HitTestRequest::Active;
     2129    HitTestRequest::HitTestRequestType hitType = HitTestRequest::DisallowUserAgentShadowContent;
     2130
     2131    if (event.force())
     2132        hitType |= HitTestRequest::Active;
    21302133
    21312134    HitTestRequest request(hitType);
Note: See TracChangeset for help on using the changeset viewer.