Changeset 230805 in webkit


Ignore:
Timestamp:
Apr 19, 2018 9:01:09 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Change MediaSource WebCore to return NewObject for SourceBuffers
https://bugs.webkit.org/show_bug.cgi?id=184642

Patch by Eric Stobbart <ericstobbart@gmail.com> on 2018-04-19
Reviewed by Chris Dumez.

Minor change inline with IDL documentation

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::addSourceBuffer):
(): Deleted.

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/MediaSource.idl:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r230799 r230805  
     12018-04-19  Eric Stobbart  <ericstobbart@gmail.com>
     2
     3        Change MediaSource WebCore to return NewObject for SourceBuffers
     4        https://bugs.webkit.org/show_bug.cgi?id=184642
     5
     6        Reviewed by Chris Dumez.
     7
     8        Minor change inline with IDL documentation
     9
     10        * Modules/mediasource/MediaSource.cpp:
     11        (WebCore::MediaSource::addSourceBuffer):
     12        (): Deleted.
     13        * Modules/mediasource/MediaSource.h:
     14        * Modules/mediasource/MediaSource.idl:
     15
    1162018-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
    217
  • trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp

    r227439 r230805  
    624624}
    625625
    626 ExceptionOr<SourceBuffer&> MediaSource::addSourceBuffer(const String& type)
     626ExceptionOr<Ref<SourceBuffer>> MediaSource::addSourceBuffer(const String& type)
    627627{
    628628    LOG(MediaSource, "MediaSource::addSourceBuffer(%s) %p", type.ascii().data(), this);
     
    670670    buffer->setMode(shouldGenerateTimestamps ? SourceBuffer::AppendMode::Sequence : SourceBuffer::AppendMode::Segments);
    671671
    672     auto& result = buffer.get();
    673 
    674672    // 8. Add the new object to sourceBuffers and fire a addsourcebuffer on that object.
    675     m_sourceBuffers->add(WTFMove(buffer));
     673    m_sourceBuffers->add(buffer.copyRef());
    676674    regenerateActiveSourceBuffers();
    677675
    678676    // 9. Return the new object to the caller.
    679     return result;
     677    return WTFMove(buffer);
    680678}
    681679
  • trunk/Source/WebCore/Modules/mediasource/MediaSource.h

    r216509 r230805  
    9292    SourceBufferList* sourceBuffers() { return m_sourceBuffers.get(); }
    9393    SourceBufferList* activeSourceBuffers() { return m_activeSourceBuffers.get(); }
    94     ExceptionOr<SourceBuffer&> addSourceBuffer(const String& type);
     94    ExceptionOr<Ref<SourceBuffer>> addSourceBuffer(const String& type);
    9595    ExceptionOr<void> removeSourceBuffer(SourceBuffer&);
    9696    static bool isTypeSupported(const String& type);
  • trunk/Source/WebCore/Modules/mediasource/MediaSource.idl

    r222429 r230805  
    5555    attribute unrestricted double duration;
    5656
    57     [MayThrowException] SourceBuffer addSourceBuffer(DOMString type);
     57    [NewObject, MayThrowException] SourceBuffer addSourceBuffer(DOMString type);
    5858    [MayThrowException] void removeSourceBuffer(SourceBuffer buffer);
    5959
Note: See TracChangeset for help on using the changeset viewer.