Changeset 230805 in webkit
- Timestamp:
- Apr 19, 2018 9:01:09 AM (6 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r230799 r230805 1 2018-04-19 Eric Stobbart <ericstobbart@gmail.com> 2 3 Change MediaSource WebCore to return NewObject for SourceBuffers 4 https://bugs.webkit.org/show_bug.cgi?id=184642 5 6 Reviewed by Chris Dumez. 7 8 Minor change inline with IDL documentation 9 10 * Modules/mediasource/MediaSource.cpp: 11 (WebCore::MediaSource::addSourceBuffer): 12 (): Deleted. 13 * Modules/mediasource/MediaSource.h: 14 * Modules/mediasource/MediaSource.idl: 15 1 16 2018-04-19 Yusuke Suzuki <utatane.tea@gmail.com> 2 17 -
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
r227439 r230805 624 624 } 625 625 626 ExceptionOr< SourceBuffer&> MediaSource::addSourceBuffer(const String& type)626 ExceptionOr<Ref<SourceBuffer>> MediaSource::addSourceBuffer(const String& type) 627 627 { 628 628 LOG(MediaSource, "MediaSource::addSourceBuffer(%s) %p", type.ascii().data(), this); … … 670 670 buffer->setMode(shouldGenerateTimestamps ? SourceBuffer::AppendMode::Sequence : SourceBuffer::AppendMode::Segments); 671 671 672 auto& result = buffer.get();673 674 672 // 8. Add the new object to sourceBuffers and fire a addsourcebuffer on that object. 675 m_sourceBuffers->add( WTFMove(buffer));673 m_sourceBuffers->add(buffer.copyRef()); 676 674 regenerateActiveSourceBuffers(); 677 675 678 676 // 9. Return the new object to the caller. 679 return result;677 return WTFMove(buffer); 680 678 } 681 679 -
trunk/Source/WebCore/Modules/mediasource/MediaSource.h
r216509 r230805 92 92 SourceBufferList* sourceBuffers() { return m_sourceBuffers.get(); } 93 93 SourceBufferList* activeSourceBuffers() { return m_activeSourceBuffers.get(); } 94 ExceptionOr< SourceBuffer&> addSourceBuffer(const String& type);94 ExceptionOr<Ref<SourceBuffer>> addSourceBuffer(const String& type); 95 95 ExceptionOr<void> removeSourceBuffer(SourceBuffer&); 96 96 static bool isTypeSupported(const String& type); -
trunk/Source/WebCore/Modules/mediasource/MediaSource.idl
r222429 r230805 55 55 attribute unrestricted double duration; 56 56 57 [ MayThrowException] SourceBuffer addSourceBuffer(DOMString type);57 [NewObject, MayThrowException] SourceBuffer addSourceBuffer(DOMString type); 58 58 [MayThrowException] void removeSourceBuffer(SourceBuffer buffer); 59 59
Note: See TracChangeset
for help on using the changeset viewer.