Changeset 230889 in webkit

Timestamp:

Apr 20, 2018 11:42:26 PM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
​https://bugs.webkit.org/show_bug.cgi?id=184815

Reviewed by Michael Catanzaro.

This is because in the test we are calling both join and detach. We should only call join.

• TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(testsJSCVirtualMachine):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
+        https://bugs.webkit.org/show_bug.cgi?id=184815
+
+        Reviewed by Michael Catanzaro.
+
+        This is because in the test we are calling both join and detach. We should only call join.
+
+        * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
+        (testsJSCVirtualMachine):
+
 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp

@@ -2511 +2511 @@
         });
         thread->waitForCompletion();
-        thread->detach();
 
         GRefPtr<JSCValue> object = adoptGRef(jsc_context_get_value(context.get(), "f"));
@@ -2551 +2550 @@
         }
 
-        for (auto& thread : threads) {
+        for (auto& thread : threads)
             thread->waitForCompletion();
-            thread->detach();
-        }
 
         g_assert_true(ok);