Context Navigation

Changeset 230910 in webkit

Timestamp:

Apr 23, 2018 6:39:53 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method
https://bugs.webkit.org/show_bug.cgi?id=184650

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-04-23
Reviewed by Philippe Normand.

In the playbin3 case we can assume that if the GstStream is selected by default,
it is the Main track of that kind.

No new tests are added as:

It relies on playbin3 case which support might be compiled out
we already have a few test that are currently disabled in the mediastream testsuite. This patch is part of the work to enable them.

(WebCore::AudioTrackPrivateGStreamer::kind const):

(WebCore::VideoTrackPrivateGStreamer::kind const):

Location:

trunk/Source/WebCore

Files:

-                      r230909
+                      r230910
+-04-23  Thibault Saunier  <tsaunier@igalia.com>
+        [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method
+        https://bugs.webkit.org/show_bug.cgi?id=184650
+        Reviewed by Philippe Normand.
+        In the playbin3 case we can assume that if the GstStream is selected by default,
+        it is the Main track of that kind.
+        No new tests are added as:
+            * It relies on playbin3 case which support might be compiled out
+            * we already have a few test that are currently disabled in the mediastream
+              testsuite. This patch is part of the work to enable them.
+        * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
+        (WebCore::AudioTrackPrivateGStreamer::kind const):
+        * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
+        * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
+        (WebCore::VideoTrackPrivateGStreamer::kind const):
+        * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
 -04-23  Alicia Boya García  <aboya@igalia.com>

-                      r230674
+                      r230910
     notifyTrackOfActiveChanged();
+}
+AudioTrackPrivate::Kind AudioTrackPrivateGStreamer::kind() const
+{
+    if (m_stream.get() && gst_stream_get_stream_flags(m_stream.get()) & GST_STREAM_FLAG_SELECT)
+        return AudioTrackPrivate::Kind::Main;
+    return AudioTrackPrivate::kind();
+}
 #endif

r230625	r230910
49	49	return adoptRef(*new AudioTrackPrivateGStreamer(player, index, stream));
50	50	}
	51
	52	Kind kind() const final;
51	53	#endif
52	54

-                      r230674
+                      r230910
     notifyTrackOfActiveChanged();
+}
+VideoTrackPrivate::Kind VideoTrackPrivateGStreamer::kind() const
+{
+    if (m_stream.get() && gst_stream_get_stream_flags(m_stream.get()) & GST_STREAM_FLAG_SELECT)
+        return VideoTrackPrivate::Kind::Main;
+    return VideoTrackPrivate::kind();
+}
 #endif

r230625	r230910
49	49	return adoptRef(*new VideoTrackPrivateGStreamer(player, index, stream));
50	50	}
	51	Kind kind() const final;
51	52	#endif
52	53

Note: See TracChangeset for help on using the changeset viewer.