Changeset 230945 in webkit


Ignore:
Timestamp:
Apr 24, 2018 12:44:06 AM (6 years ago)
Author:
dbates@webkit.org
Message:

Fix up order of ChangeLog entries following r230944.

Location:
trunk/Source
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r230944 r230945  
    1 2018-04-23  Youenn Fablet  <youenn@apple.com>
    2 
    3         Make WebLoaderStrategy send to NetworkResourceLoader necessary parameters to handle full loads in NetworkProcess
    4         https://bugs.webkit.org/show_bug.cgi?id=184763
    5 
    6         Reviewed by Chris Dumez.
    7 
    8         No change of behavior yet since we do not use these parameters in NetworkProcess yet.
    9 
    10         Add PreflightPolicy and CSP response headers as ResourceLoaderOptions.
    11         This allows passing them from DocumentThreadableLoader to WebLoaderStrategy.
    12 
    13         Allow getting the original headers from a SubresourceLoader.
    14         This allows passing them from DocumentThreadableLoader down to WebLoaderStrategy.
    15 
    16         * Modules/fetch/FetchLoader.cpp:
    17         (WebCore::FetchLoader::startLoadingBlobURL):
    18         (WebCore::FetchLoader::start):
    19         * loader/DocumentThreadableLoader.cpp:
    20         (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
    21         (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
    22         (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
    23         * loader/ResourceLoaderOptions.h:
    24         * loader/SubresourceLoader.cpp:
    25         (WebCore::SubresourceLoader::originalHeaders const):
    26         * loader/SubresourceLoader.h:
    27         * loader/ThreadableLoader.cpp:
    28         (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
    29         (WebCore::ThreadableLoaderOptions::isolatedCopy const):
    30         * loader/ThreadableLoader.h:
    31         * page/EventSource.cpp:
    32         (WebCore::EventSource::connect):
    33         * xml/XMLHttpRequest.cpp:
    34         (WebCore::XMLHttpRequest::createRequest):
    35 
    36 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
    37 
    38         [WPE][GTK] Remove WlUniquePtr<wl_display> footgun
    39         https://bugs.webkit.org/show_bug.cgi?id=184405
    40 
    41         Reviewed by Carlos Garcia Campos.
    42 
    43         WlUniquePtr<wl_display> is a pretty big footgun because there are two different destruction
    44         functions -- wl_display_disconnect() and wl_display_destroy() -- and which one you need to
    45         use depends on how the wl_display() was created, and WebKit uses both in different places.
    46         So WlUniquePtr<wl_display> is pretty unsafe. See bug #176490 for an example of fun caused
    47         by using it incorrectly.
    48 
    49         Let's use std::unique_ptr with custom deleter functors instead.
    50 
    51         * platform/graphics/wayland/WlUniquePtr.h:
    52 
    5312018-04-23  Daniel Bates  <dabates@apple.com>
    542
    … …  
    219167        (WebCore::XSLTProcessor::createDocumentFromSource): Copy the first party for same-site cookies to the
    220168        new document.
     169
     1702018-04-23  Youenn Fablet  <youenn@apple.com>
     171
     172        Make WebLoaderStrategy send to NetworkResourceLoader necessary parameters to handle full loads in NetworkProcess
     173        https://bugs.webkit.org/show_bug.cgi?id=184763
     174
     175        Reviewed by Chris Dumez.
     176
     177        No change of behavior yet since we do not use these parameters in NetworkProcess yet.
     178
     179        Add PreflightPolicy and CSP response headers as ResourceLoaderOptions.
     180        This allows passing them from DocumentThreadableLoader to WebLoaderStrategy.
     181
     182        Allow getting the original headers from a SubresourceLoader.
     183        This allows passing them from DocumentThreadableLoader down to WebLoaderStrategy.
     184
     185        * Modules/fetch/FetchLoader.cpp:
     186        (WebCore::FetchLoader::startLoadingBlobURL):
     187        (WebCore::FetchLoader::start):
     188        * loader/DocumentThreadableLoader.cpp:
     189        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
     190        (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
     191        (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
     192        * loader/ResourceLoaderOptions.h:
     193        * loader/SubresourceLoader.cpp:
     194        (WebCore::SubresourceLoader::originalHeaders const):
     195        * loader/SubresourceLoader.h:
     196        * loader/ThreadableLoader.cpp:
     197        (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
     198        (WebCore::ThreadableLoaderOptions::isolatedCopy const):
     199        * loader/ThreadableLoader.h:
     200        * page/EventSource.cpp:
     201        (WebCore::EventSource::connect):
     202        * xml/XMLHttpRequest.cpp:
     203        (WebCore::XMLHttpRequest::createRequest):
     204
     2052018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
     206
     207        [WPE][GTK] Remove WlUniquePtr<wl_display> footgun
     208        https://bugs.webkit.org/show_bug.cgi?id=184405
     209
     210        Reviewed by Carlos Garcia Campos.
     211
     212        WlUniquePtr<wl_display> is a pretty big footgun because there are two different destruction
     213        functions -- wl_display_disconnect() and wl_display_destroy() -- and which one you need to
     214        use depends on how the wl_display() was created, and WebKit uses both in different places.
     215        So WlUniquePtr<wl_display> is pretty unsafe. See bug #176490 for an example of fun caused
     216        by using it incorrectly.
     217
     218        Let's use std::unique_ptr with custom deleter functors instead.
     219
     220        * platform/graphics/wayland/WlUniquePtr.h:
    221221
    2222222018-04-23  Antti Koivisto  <antti@apple.com>

  • trunk/Source/WebKit/ChangeLog

    r230944 r230945  
    1 2018-04-23  Youenn Fablet  <youenn@apple.com>
    2 
    3         Make WebLoaderStrategy send to NetworkResourceLoader necessary parameters to handle full loads in NetworkProcess
    4         https://bugs.webkit.org/show_bug.cgi?id=184763
    5 
    6         Reviewed by Chris Dumez.
    7 
    8         Set all required NetworkResourceLoadParameters for asynchronous loads.
    9         This includes preflight policy, CSP response headers, SecurityOrigin and content blockers identifier.
    10 
    11         Update NetworkLoadChecker to handle preflight policy.
    12         This is not needed right now since sync XHR and ping loads are using the default ConsiderPreflight policy.
    13         But this will be needed for XHR/fetch/EventSource loads.
    14 
    15         * NetworkProcess/NetworkLoadChecker.cpp:
    16         (WebKit::NetworkLoadChecker::NetworkLoadChecker):
    17         (WebKit::NetworkLoadChecker::checkRedirection):
    18         (WebKit::NetworkLoadChecker::validateResponse):
    19         (WebKit::NetworkLoadChecker::checkCORSRequest):
    20         * NetworkProcess/NetworkLoadChecker.h:
    21         (WebKit::NetworkLoadChecker::create):
    22         * NetworkProcess/NetworkResourceLoadParameters.cpp:
    23         (WebKit::NetworkResourceLoadParameters::encode const):
    24         (WebKit::NetworkResourceLoadParameters::decode):
    25         * NetworkProcess/NetworkResourceLoadParameters.h:
    26         * NetworkProcess/NetworkResourceLoader.cpp:
    27         * NetworkProcess/PingLoad.cpp:
    28         (WebKit::PingLoad::PingLoad):
    29         * WebProcess/Network/WebLoaderStrategy.cpp:
    30         (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
    31 
    32 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
    33 
    34         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
    35         https://bugs.webkit.org/show_bug.cgi?id=184901
    36         <rdar://problem/39664797>
    37 
    38         Reviewed by Tim Horton.
    39 
    40         Fixes the bug by falling back to setting the value of the focused input element in the case where the selection
    41         is not editable. Also adds plumbing to make time pickers testable in extra zoom mode.
    42 
    43         * UIProcess/API/Cocoa/WKWebView.mm:
    44         (-[WKWebView setTimePickerValueToHour:minute:]):
    45         * UIProcess/API/Cocoa/WKWebViewPrivate.h:
    46         * UIProcess/ios/WKContentViewInteraction.h:
    47         * UIProcess/ios/WKContentViewInteraction.mm:
    48         (-[WKContentView setTimePickerValueToHour:minute:]):
    49 
    50         Add plumbing to make it possible for WebKitTestRunner to simulate picking a time from the given hours and
    51         minutes. This is currently only implemented for extra zoom mode, but may be implemented for UIKit's time picker
    52         as well in the future by adjusting -[WKContentView setTimePickerValueToHour:minute:].
    53 
    54         * WebProcess/WebPage/WebPage.cpp:
    55         (WebKit::WebPage::setTextAsync):
    56 
    57 2018-04-23  Saam Barati  <sbarati@apple.com>
    58 
    59         Keep around a pre-warmed process when doing process swap on navigation
    60         https://bugs.webkit.org/show_bug.cgi?id=184765
    61 
    62         Reviewed by Ryosuke Niwa.
    63 
    64         This patch makes it so that WebProcessPool prewarms a process when process
    65         swap on navigation is turned on. When we do a process swap on navigation,
    66         we first try to grab a prewarmed process before creating a new one.
    67        
    68         We try to be smart about when to create these processes. The initial heuristic
    69         that this patch chooses is when we reach the DidFirstVisuallyNonEmptyLayout
    70         layout milestone. We're going to try to improve on this heuristic in:
    71         https://bugs.webkit.org/show_bug.cgi?id=184899
    72        
    73         This is a 40% progression on PLT with process swap on navigation turned on.
    74 
    75         * UIProcess/ServiceWorkerProcessProxy.cpp:
    76         (WebKit::ServiceWorkerProcessProxy::ServiceWorkerProcessProxy):
    77         * UIProcess/WebPageProxy.cpp:
    78         (WebKit::WebPageProxy::notifyProcessPoolToPrewarm):
    79         (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
    80         * UIProcess/WebPageProxy.h:
    81         * UIProcess/WebProcessPool.cpp:
    82         (WebKit::WebProcessPool::createNewWebProcess):
    83         (WebKit::WebProcessPool::tryTakePrewarmedProcess):
    84         (WebKit::WebProcessPool::warmInitialProcess):
    85         (WebKit::WebProcessPool::disconnectProcess):
    86         (WebKit::WebProcessPool::createWebPage):
    87         (WebKit::WebProcessPool::didReachGoodTimeToPrewarm):
    88         (WebKit::WebProcessPool::processForNavigation):
    89         * UIProcess/WebProcessPool.h:
    90         * UIProcess/WebProcessProxy.cpp:
    91         (WebKit::WebProcessProxy::create):
    92         (WebKit::WebProcessProxy::WebProcessProxy):
    93         (WebKit::m_isInPrewarmedPool):
    94         (WebKit::m_userMediaCaptureManagerProxy): Deleted.
    95         * UIProcess/WebProcessProxy.h:
    96         (WebKit::WebProcessProxy::isInPrewarmedPool const):
    97         (WebKit::WebProcessProxy::setIsInPrewarmedPool):
    98 
    99 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
    100 
    101         [WPE][GTK] Remove WlUniquePtr<wl_display> footgun
    102         https://bugs.webkit.org/show_bug.cgi?id=184405
    103 
    104         Reviewed by Carlos Garcia Campos.
    105 
    106         Switch to std::unique_ptr.
    107 
    108         * UIProcess/gtk/WaylandCompositor.cpp:
    109         (WebKit::WaylandCompositor::WaylandCompositor):
    110         * UIProcess/gtk/WaylandCompositor.h:
    111         (WebKit::WaylandCompositor::DisplayDeleter::operator()):
    112 
    11312018-04-23  Daniel Bates  <dabates@apple.com>
    1142
    … …  
    15745        (WebKit::WebPlatformStrategies::getRawCookies):
    15846        * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
     47
     482018-04-23  Youenn Fablet  <youenn@apple.com>
     49
     50        Make WebLoaderStrategy send to NetworkResourceLoader necessary parameters to handle full loads in NetworkProcess
     51        https://bugs.webkit.org/show_bug.cgi?id=184763
     52
     53        Reviewed by Chris Dumez.
     54
     55        Set all required NetworkResourceLoadParameters for asynchronous loads.
     56        This includes preflight policy, CSP response headers, SecurityOrigin and content blockers identifier.
     57
     58        Update NetworkLoadChecker to handle preflight policy.
     59        This is not needed right now since sync XHR and ping loads are using the default ConsiderPreflight policy.
     60        But this will be needed for XHR/fetch/EventSource loads.
     61
     62        * NetworkProcess/NetworkLoadChecker.cpp:
     63        (WebKit::NetworkLoadChecker::NetworkLoadChecker):
     64        (WebKit::NetworkLoadChecker::checkRedirection):
     65        (WebKit::NetworkLoadChecker::validateResponse):
     66        (WebKit::NetworkLoadChecker::checkCORSRequest):
     67        * NetworkProcess/NetworkLoadChecker.h:
     68        (WebKit::NetworkLoadChecker::create):
     69        * NetworkProcess/NetworkResourceLoadParameters.cpp:
     70        (WebKit::NetworkResourceLoadParameters::encode const):
     71        (WebKit::NetworkResourceLoadParameters::decode):
     72        * NetworkProcess/NetworkResourceLoadParameters.h:
     73        * NetworkProcess/NetworkResourceLoader.cpp:
     74        * NetworkProcess/PingLoad.cpp:
     75        (WebKit::PingLoad::PingLoad):
     76        * WebProcess/Network/WebLoaderStrategy.cpp:
     77        (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
     78
     792018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
     80
     81        [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
     82        https://bugs.webkit.org/show_bug.cgi?id=184901
     83        <rdar://problem/39664797>
     84
     85        Reviewed by Tim Horton.
     86
     87        Fixes the bug by falling back to setting the value of the focused input element in the case where the selection
     88        is not editable. Also adds plumbing to make time pickers testable in extra zoom mode.
     89
     90        * UIProcess/API/Cocoa/WKWebView.mm:
     91        (-[WKWebView setTimePickerValueToHour:minute:]):
     92        * UIProcess/API/Cocoa/WKWebViewPrivate.h:
     93        * UIProcess/ios/WKContentViewInteraction.h:
     94        * UIProcess/ios/WKContentViewInteraction.mm:
     95        (-[WKContentView setTimePickerValueToHour:minute:]):
     96
     97        Add plumbing to make it possible for WebKitTestRunner to simulate picking a time from the given hours and
     98        minutes. This is currently only implemented for extra zoom mode, but may be implemented for UIKit's time picker
     99        as well in the future by adjusting -[WKContentView setTimePickerValueToHour:minute:].
     100
     101        * WebProcess/WebPage/WebPage.cpp:
     102        (WebKit::WebPage::setTextAsync):
     103
     1042018-04-23  Saam Barati  <sbarati@apple.com>
     105
     106        Keep around a pre-warmed process when doing process swap on navigation
     107        https://bugs.webkit.org/show_bug.cgi?id=184765
     108
     109        Reviewed by Ryosuke Niwa.
     110
     111        This patch makes it so that WebProcessPool prewarms a process when process
     112        swap on navigation is turned on. When we do a process swap on navigation,
     113        we first try to grab a prewarmed process before creating a new one.
     114       
     115        We try to be smart about when to create these processes. The initial heuristic
     116        that this patch chooses is when we reach the DidFirstVisuallyNonEmptyLayout
     117        layout milestone. We're going to try to improve on this heuristic in:
     118        https://bugs.webkit.org/show_bug.cgi?id=184899
     119       
     120        This is a 40% progression on PLT with process swap on navigation turned on.
     121
     122        * UIProcess/ServiceWorkerProcessProxy.cpp:
     123        (WebKit::ServiceWorkerProcessProxy::ServiceWorkerProcessProxy):
     124        * UIProcess/WebPageProxy.cpp:
     125        (WebKit::WebPageProxy::notifyProcessPoolToPrewarm):
     126        (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
     127        * UIProcess/WebPageProxy.h:
     128        * UIProcess/WebProcessPool.cpp:
     129        (WebKit::WebProcessPool::createNewWebProcess):
     130        (WebKit::WebProcessPool::tryTakePrewarmedProcess):
     131        (WebKit::WebProcessPool::warmInitialProcess):
     132        (WebKit::WebProcessPool::disconnectProcess):
     133        (WebKit::WebProcessPool::createWebPage):
     134        (WebKit::WebProcessPool::didReachGoodTimeToPrewarm):
     135        (WebKit::WebProcessPool::processForNavigation):
     136        * UIProcess/WebProcessPool.h:
     137        * UIProcess/WebProcessProxy.cpp:
     138        (WebKit::WebProcessProxy::create):
     139        (WebKit::WebProcessProxy::WebProcessProxy):
     140        (WebKit::m_isInPrewarmedPool):
     141        (WebKit::m_userMediaCaptureManagerProxy): Deleted.
     142        * UIProcess/WebProcessProxy.h:
     143        (WebKit::WebProcessProxy::isInPrewarmedPool const):
     144        (WebKit::WebProcessProxy::setIsInPrewarmedPool):
     145
     1462018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
     147
     148        [WPE][GTK] Remove WlUniquePtr<wl_display> footgun
     149        https://bugs.webkit.org/show_bug.cgi?id=184405
     150
     151        Reviewed by Carlos Garcia Campos.
     152
     153        Switch to std::unique_ptr.
     154
     155        * UIProcess/gtk/WaylandCompositor.cpp:
     156        (WebKit::WaylandCompositor::WaylandCompositor):
     157        * UIProcess/gtk/WaylandCompositor.h:
     158        (WebKit::WaylandCompositor::DisplayDeleter::operator()):
    159159
    1601602018-04-23  Daniel Bates  <dabates@apple.com>
Note: See TracChangeset for help on using the changeset viewer.