Changeset 231179 in webkit

Timestamp:

Apr 30, 2018 4:42:22 PM (6 years ago)

Author:

jer.noble@apple.com

Message:

<img src=mp4> does not display on ios despite Accept: video/* advertisement
​https://bugs.webkit.org/show_bug.cgi?id=185029
<rdar://problem/39771989>

Reviewed by Eric Carlson.

Source/WebCore:

Returning "NO" from resourceLoader:shouldWaitForLoadingOfResource: signals that the load failed,
even if the resource request is successfully fulfilled prior to the return. Always return YES in
the case that loading succeeded.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):

LayoutTests:

• platform/ios/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-04-30  Jer Noble  <jer.noble@apple.com>
+
+        <img src=mp4> does not display on ios despite Accept: video/* advertisement
+        https://bugs.webkit.org/show_bug.cgi?id=185029
+        <rdar://problem/39771989>
+
+        Reviewed by Eric Carlson.
+
+        * platform/ios/TestExpectations:
+
 2018-04-30  Zalan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/platform/ios/TestExpectations

@@ -1112 +1112 @@
 fast/css/variables/env/ios [ Pass ]
 
-# This test relies on APIs not available on iOS
-fast/images/animated-image-mp4.html [ Skip ]
-
-
 ###
 # Known failures

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-30  Jer Noble  <jer.noble@apple.com>
+
+        <img src=mp4> does not display on ios despite Accept: video/* advertisement
+        https://bugs.webkit.org/show_bug.cgi?id=185029
+        <rdar://problem/39771989>
+
+        Reviewed by Eric Carlson.
+
+        Returning "NO" from resourceLoader:shouldWaitForLoadingOfResource: signals that the load failed,
+        even if the resource request is successfully fulfilled prior to the return. Always return YES in
+        the case that loading succeeded.
+
+        * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
+        (-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
+
 2018-04-30  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm

@@ -204 +204 @@
         [self fulfillRequest:loadingRequest];
         if (loadingRequest.finished)
-            return NO;
+            return YES;
     }