Changeset 231255 in webkit

Timestamp:

May 2, 2018 12:53:38 PM (6 years ago)

Author:

youenn@apple.com

Message:

Layout Test http/wpt/service-workers/header-filtering.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=184469
<rdar://problem/39428226>

Reviewed by Chris Dumez.

Ensure that the message posted for the loading of the initial iframe is actually received before doing further tests.

• http/wpt/service-workers/header-filtering.https.html:
• platform/mac-wk2/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/wpt/service-workers/header-filtering.https.html (modified) (1 diff)
• platform/mac-wk2/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-02  Youenn Fablet  <youenn@apple.com>
+
+        Layout Test http/wpt/service-workers/header-filtering.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=184469
+        <rdar://problem/39428226>
+
+        Reviewed by Chris Dumez.
+
+        Ensure that the message posted for the loading of the initial iframe is actually received before doing further tests.
+
+        * http/wpt/service-workers/header-filtering.https.html:
+        * platform/mac-wk2/TestExpectations:
+
 2018-05-02  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/http/wpt/service-workers/header-filtering.https.html

@@ -41 +41 @@
 }
 
+var processMessage;
 promise_test(async (test) => {
     registration = await registerServiceWorker(scope);
     registration.active.postMessage("ready?");
+
+    navigator.serviceWorker.onmessage = (event) => {
+        processMessage(event.data);
+    };
+
     return new Promise((resolve) => {
-        navigator.serviceWorker.onmessage = (event) => {
+        processMessage = (data) => {
             assert_equals(event.data, "ready");
-            navigator.serviceWorker.onmessage = undefined;
             resolve();
-        };
+        }
     });
 }, "Prepare tests: setup worker and register the client");
 
-var processMessage;
 promise_test(async (test) => {
+    const promise = new Promise((resolve) => {
+        processMessage = (data) => {
+            resolve(data);
+        };
+    });
     frame = await withFrame(scope + "/header-filtering-iframe.html");
-    navigator.serviceWorker.onmessage = (event) => {
-        processMessage(event.data);
-    };
+    await promise;
 }, "Prepare tests: Add a frame controlled by service worker");
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -886 +886 @@
 webkit.org/b/177380 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]
 
-webkit.org/b/184469 http/wpt/service-workers/header-filtering.https.html [ Pass Failure ]