Changeset 231325 in webkit


Ignore:
Timestamp:
May 3, 2018 1:52:46 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Remove [NoInterfaceObject] from DOMRectList
​https://bugs.webkit.org/show_bug.cgi?id=185255

Patch by Chris Nardi <​cnardi@chromium.org> on 2018-05-03
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update Geometry IDL test from upstream and update expectations.

  • web-platform-tests/css/geometry/interfaces-expected.txt:
  • web-platform-tests/css/geometry/interfaces.worker-expected.txt:
  • web-platform-tests/interfaces/geometry.idl:

Source/WebCore:

In ​https://github.com/w3c/fxtf-drafts/issues/233, [NoInterfaceObject] was removed
from DOMRectList. Remove it from our implementation to match the spec, as well as
Chrome and Firefox.

Updated web platform tests IDL test for the Geometry spec.

  • dom/DOMRectList.idl:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r231274 r231325  
     12018-05-03  Chris Nardi  <cnardi@chromium.org>
     2
     3        Remove [NoInterfaceObject] from DOMRectList
     4        https://bugs.webkit.org/show_bug.cgi?id=185255
     5
     6        Reviewed by Chris Dumez.
     7
     8        Update Geometry IDL test from upstream and update expectations.
     9
     10        * web-platform-tests/css/geometry/interfaces-expected.txt:
     11        * web-platform-tests/css/geometry/interfaces.worker-expected.txt:
     12        * web-platform-tests/interfaces/geometry.idl:
     13
    1142018-05-02  Youenn Fablet  <youenn@apple.com>
    215

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces-expected.txt

    r230285 r231325  
    1919PASS DOMPointReadOnly interface: operation matrixTransform(DOMMatrixInit)
    2020PASS Unscopable handled correctly for matrixTransform(DOMMatrixInit) on DOMPointReadOnly
     21PASS DOMPointReadOnly interface: operation toJSON()
     22PASS Unscopable handled correctly for toJSON() on DOMPointReadOnly
    2123PASS DOMPointReadOnly must be primary interface of new DOMPointReadOnly()
    2224PASS Stringification of new DOMPointReadOnly()
    … …  
    2931PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type
    3032PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPointReadOnly() with too few arguments must throw TypeError
     33PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "toJSON()" with the proper type
     34PASS Test default toJSON operation of DOMPointReadOnly
    3135PASS DOMPoint interface: existence and properties of interface object
    3236PASS DOMPoint interface object length
    … …  
    6670PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type
    6771PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPoint() with too few arguments must throw TypeError
     72PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "toJSON()" with the proper type
     73PASS Test default toJSON operation of DOMPoint
    6874PASS DOMRectReadOnly interface: existence and properties of interface object
    6975PASS DOMRectReadOnly interface object length
    … …  
    9096PASS DOMRectReadOnly interface: attribute left
    9197PASS Unscopable handled correctly for left property on DOMRectReadOnly
     98PASS DOMRectReadOnly interface: operation toJSON()
     99PASS Unscopable handled correctly for toJSON() on DOMRectReadOnly
    92100PASS DOMRectReadOnly must be primary interface of new DOMRectReadOnly()
    93101PASS Stringification of new DOMRectReadOnly()
    … …  
    102110PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "bottom" with the proper type
    103111PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "left" with the proper type
     112PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "toJSON()" with the proper type
     113PASS Test default toJSON operation of DOMRectReadOnly
    104114PASS DOMRect interface: existence and properties of interface object
    105115PASS DOMRect interface object length
    … …  
    141151PASS DOMRectReadOnly interface: new DOMRect() must inherit property "bottom" with the proper type
    142152PASS DOMRectReadOnly interface: new DOMRect() must inherit property "left" with the proper type
     153PASS DOMRectReadOnly interface: new DOMRect() must inherit property "toJSON()" with the proper type
     154PASS Test default toJSON operation of DOMRect
     155PASS DOMRectList interface: existence and properties of interface object
     156PASS DOMRectList interface object length
     157PASS DOMRectList interface object name
     158PASS DOMRectList interface: existence and properties of interface prototype object
     159PASS DOMRectList interface: existence and properties of interface prototype object's "constructor" property
     160PASS DOMRectList interface: existence and properties of interface prototype object's @@unscopables property
     161PASS DOMRectList interface: attribute length
     162PASS Unscopable handled correctly for length property on DOMRectList
     163PASS DOMRectList interface: operation item(unsigned long)
     164PASS Unscopable handled correctly for item(unsigned long) on DOMRectList
     165PASS DOMRectList must be primary interface of [object DOMRectList]
    143166PASS Stringification of [object DOMRectList]
    144167PASS DOMRectList interface: [object DOMRectList] must inherit property "length" with the proper type
    … …  
    165188PASS DOMQuad interface: operation getBounds()
    166189PASS Unscopable handled correctly for getBounds() on DOMQuad
     190PASS DOMQuad interface: operation toJSON()
     191PASS Unscopable handled correctly for toJSON() on DOMQuad
    167192PASS DOMQuad must be primary interface of new DOMQuad()
    168193PASS Stringification of new DOMQuad()
    … …  
    176201PASS DOMQuad interface: new DOMQuad() must inherit property "p4" with the proper type
    177202PASS DOMQuad interface: new DOMQuad() must inherit property "getBounds()" with the proper type
     203PASS DOMQuad interface: new DOMQuad() must inherit property "toJSON()" with the proper type
     204FAIL Test default toJSON operation of DOMQuad assert_true: instanceof DOMPoint expected true got false
    178205PASS DOMMatrixReadOnly interface: existence and properties of interface object
    179206PASS DOMMatrixReadOnly interface object length
    … …  
    267294PASS Unscopable handled correctly for toFloat64Array() on DOMMatrixReadOnly
    268295PASS DOMMatrixReadOnly interface: stringifier
     296PASS DOMMatrixReadOnly interface: operation toJSON()
     297PASS Unscopable handled correctly for toJSON() on DOMMatrixReadOnly
    269298PASS DOMMatrixReadOnly must be primary interface of new DOMMatrixReadOnly()
    270299PASS Stringification of new DOMMatrixReadOnly()
    … …  
    324353PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toFloat32Array()" with the proper type
    325354PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toFloat64Array()" with the proper type
     355PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toJSON()" with the proper type
     356PASS Test default toJSON operation of DOMMatrixReadOnly
    326357PASS DOMMatrixReadOnly must be primary interface of DOMMatrixReadOnly.fromMatrix({is2D: false})
    327358PASS Stringification of DOMMatrixReadOnly.fromMatrix({is2D: false})

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/geometry/interfaces.worker-expected.txt

    r230285 r231325  
    1919PASS DOMPointReadOnly interface: operation matrixTransform(DOMMatrixInit)
    2020PASS Unscopable handled correctly for matrixTransform(DOMMatrixInit) on DOMPointReadOnly
     21PASS DOMPointReadOnly interface: operation toJSON()
     22PASS Unscopable handled correctly for toJSON() on DOMPointReadOnly
    2123PASS DOMPointReadOnly must be primary interface of new DOMPointReadOnly()
    2224PASS Stringification of new DOMPointReadOnly()
    … …  
    2931PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type
    3032PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPointReadOnly() with too few arguments must throw TypeError
     33PASS DOMPointReadOnly interface: new DOMPointReadOnly() must inherit property "toJSON()" with the proper type
     34PASS Test default toJSON operation of DOMPointReadOnly
    3135PASS DOMPoint interface: existence and properties of interface object
    3236PASS DOMPoint interface object length
    … …  
    6266PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "matrixTransform(DOMMatrixInit)" with the proper type
    6367PASS DOMPointReadOnly interface: calling matrixTransform(DOMMatrixInit) on new DOMPoint() with too few arguments must throw TypeError
     68PASS DOMPointReadOnly interface: new DOMPoint() must inherit property "toJSON()" with the proper type
     69PASS Test default toJSON operation of DOMPoint
    6470PASS DOMRectReadOnly interface: existence and properties of interface object
    6571PASS DOMRectReadOnly interface object length
    … …  
    8692PASS DOMRectReadOnly interface: attribute left
    8793PASS Unscopable handled correctly for left property on DOMRectReadOnly
     94PASS DOMRectReadOnly interface: operation toJSON()
     95PASS Unscopable handled correctly for toJSON() on DOMRectReadOnly
    8896PASS DOMRectReadOnly must be primary interface of new DOMRectReadOnly()
    8997PASS Stringification of new DOMRectReadOnly()
    … …  
    98106PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "bottom" with the proper type
    99107PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "left" with the proper type
     108PASS DOMRectReadOnly interface: new DOMRectReadOnly() must inherit property "toJSON()" with the proper type
     109PASS Test default toJSON operation of DOMRectReadOnly
    100110PASS DOMRect interface: existence and properties of interface object
    101111PASS DOMRect interface object length
    … …  
    133143PASS DOMRectReadOnly interface: new DOMRect() must inherit property "bottom" with the proper type
    134144PASS DOMRectReadOnly interface: new DOMRect() must inherit property "left" with the proper type
     145PASS DOMRectReadOnly interface: new DOMRect() must inherit property "toJSON()" with the proper type
     146PASS Test default toJSON operation of DOMRect
     147PASS DOMRectList interface: existence and properties of interface object
    135148PASS DOMQuad interface: existence and properties of interface object
    136149PASS DOMQuad interface object length
    … …  
    153166PASS DOMQuad interface: operation getBounds()
    154167PASS Unscopable handled correctly for getBounds() on DOMQuad
     168PASS DOMQuad interface: operation toJSON()
     169PASS Unscopable handled correctly for toJSON() on DOMQuad
    155170PASS DOMQuad must be primary interface of new DOMQuad()
    156171PASS Stringification of new DOMQuad()
    … …  
    164179PASS DOMQuad interface: new DOMQuad() must inherit property "p4" with the proper type
    165180PASS DOMQuad interface: new DOMQuad() must inherit property "getBounds()" with the proper type
     181PASS DOMQuad interface: new DOMQuad() must inherit property "toJSON()" with the proper type
     182FAIL Test default toJSON operation of DOMQuad assert_true: instanceof DOMPoint expected true got false
    166183PASS DOMMatrixReadOnly interface: existence and properties of interface object
    167184PASS DOMMatrixReadOnly interface object length
    … …  
    255272PASS Unscopable handled correctly for toFloat64Array() on DOMMatrixReadOnly
    256273PASS DOMMatrixReadOnly interface: member undefined
     274PASS DOMMatrixReadOnly interface: operation toJSON()
     275PASS Unscopable handled correctly for toJSON() on DOMMatrixReadOnly
    257276PASS DOMMatrixReadOnly must be primary interface of new DOMMatrixReadOnly()
    258277PASS Stringification of new DOMMatrixReadOnly()
    … …  
    313332PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toFloat64Array()" with the proper type
    314333PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must not have property "undefined"
     334PASS DOMMatrixReadOnly interface: new DOMMatrixReadOnly() must inherit property "toJSON()" with the proper type
     335PASS Test default toJSON operation of DOMMatrixReadOnly
    315336PASS DOMMatrixReadOnly must be primary interface of DOMMatrixReadOnly.fromMatrix({is2D: false})
    316337PASS Stringification of DOMMatrixReadOnly.fromMatrix({is2D: false})

  • trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/geometry.idl

    r222545 r231325  
     1// GENERATED CONTENT - DO NOT EDIT
     2// Content of this file was automatically extracted from the Geometry Interfaces spec.
     3// See https://drafts.fxtf.org/geometry/
     4
    15[Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
    26             optional unrestricted double z = 0, optional unrestricted double w = 1),
    … …  
    1317    DOMPoint matrixTransform(optional DOMMatrixInit matrix);
    1418
    15     [Default] toJSON();
     19    [Default] object toJSON();
    1620};
    1721
    … …  
    5357    readonly attribute unrestricted double left;
    5458
    55     [Default] toJSON();
     59    [Default] object toJSON();
    5660};
    5761
    … …  
    7781};
    7882
    79 [NoInterfaceObject,
    80  LegacyArrayClass]
    8183interface DOMRectList {
    8284    readonly attribute unsigned long length;
    … …  
    98100    [NewObject] DOMRect getBounds();
    99101
    100     [Default] toJSON();
     102    [Default] object toJSON();
    101103};
    102104
    … …  
    179181
    180182    [Exposed=Window] stringifier;
    181     [Default] toJSON();
     183    [Default] object toJSON();
    182184};
    183185

  • trunk/Source/WebCore/ChangeLog

    r231319 r231325  
     12018-05-03  Chris Nardi  <cnardi@chromium.org>
     2
     3        Remove [NoInterfaceObject] from DOMRectList
     4        https://bugs.webkit.org/show_bug.cgi?id=185255
     5
     6        Reviewed by Chris Dumez.
     7
     8        In https://github.com/w3c/fxtf-drafts/issues/233, [NoInterfaceObject] was removed
     9        from DOMRectList. Remove it from our implementation to match the spec, as well as
     10        Chrome and Firefox.
     11
     12        Updated web platform tests IDL test for the Geometry spec.
     13
     14        * dom/DOMRectList.idl:
     15
    1162018-05-03  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/dom/DOMRectList.idl

    r217576 r231325  
    2626[
    2727     ExportMacro=WEBCORE_EXPORT,
    28      ImplementationLacksVTable,
    29      NoInterfaceObject
     28     ImplementationLacksVTable
    3029] interface DOMRectList {
    3130    readonly attribute unsigned long length;
Note: See TracChangeset for help on using the changeset viewer.