Changeset 231600 in webkit


Ignore:
Timestamp:
May 9, 2018 3:04:54 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

[GStreamer] Never call updateTracks if running on legacy pipeline
https://bugs.webkit.org/show_bug.cgi?id=184581

Source/WebCore:

This makes sure failling code path is never reached in the conditions where it should not have been reached.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-05-09
Reviewed by Philippe Normand.

Re enables all tests that were disabled after fixing.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

LayoutTests:

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-05-09
Reviewed by Philippe Normand.

https://bugs.webkit.org/show_bug.cgi?id=185252

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r231599 r231600  
     12018-05-09  Thibault Saunier  <tsaunier@igalia.com>
     2
     3        [GStreamer] Never call updateTracks if running on legacy pipeline
     4        https://bugs.webkit.org/show_bug.cgi?id=184581
     5
     6        Reviewed by Philippe Normand.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=185252
     9
     10        * platform/gtk/TestExpectations:
     11
    1122018-05-09  Ross Kirsling  <ross.kirsling@sony.com>
    213
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r231549 r231600  
    10061006webkit.org/b/154390 http/tests/media/video-throttled-load-metadata.html [ Pass Failure ]
    10071007webkit.org/b/154390 http/tests/media/video-redirect.html [ Timeout Pass ]
     1008webkit.org/b/154390 [ Release ] http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure ]
     1009webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure ]
    10081010webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-video-resize.html [ Timeout Failure ]
    10091011webkit.org/b/154390 http/tests/security/local-video-source-from-remote.html [ Timeout Pass ]
     
    12461248
    12471249webkit.org/b/152043 [ Debug ] http/tests/media/hls [ Timeout Crash ]
    1248 
    1249 # Tests crashing since addition of playbin3 usage
    1250 webkit.org/b/184581 http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure Crash ]
    1251 webkit.org/b/184581 http/tests/media/hls/hls-progress.html [ Crash ]
    1252 webkit.org/b/184581 http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure Crash ]
    12531250
    12541251webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Crash Pass Timeout Failure ]
     
    33593356webkit.org/b/184779 transitions/clip-path-transitions.html [ Failure ]
    33603357
    3361 webkit.org/b/185252 http/tests/media/hls/hls-audio-tracks.html [ Failure ]
    3362 
    33633358webkit.org/b/185254 http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ]
    33643359webkit.org/b/185254 http/tests/xmlhttprequest/onloadend-event-after-error.html [ Failure ]
  • trunk/Source/WebCore/ChangeLog

    r231597 r231600  
     12018-05-09  Thibault Saunier  <tsaunier@igalia.com>
     2
     3        [GStreamer] Never call updateTracks if running on legacy pipeline
     4        https://bugs.webkit.org/show_bug.cgi?id=184581
     5
     6        This makes sure failling code path is never reached in the conditions where it should not have been reached.
     7
     8        Reviewed by Philippe Normand.
     9
     10        Re enables all tests that were disabled after fixing.
     11
     12        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
     13        (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
     14
    1152018-05-09  Daniel Bates  <dabates@apple.com>
    216
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

    r231581 r231600  
    12961296#if GST_CHECK_VERSION(1, 10, 0)
    12971297    case GST_MESSAGE_STREAM_COLLECTION: {
     1298        if (m_isLegacyPlaybin)
     1299            break;
     1300
    12981301        GRefPtr<GstStreamCollection> collection;
    12991302        gst_message_parse_stream_collection(message, &collection.outPtr());
Note: See TracChangeset for help on using the changeset viewer.