Changeset 231628 in webkit

Timestamp:

May 9, 2018 7:07:34 PM (6 years ago)

Author:

n_wang@apple.com

Message:

AX: VoiceOver iframe scrolling focus jumping bug
​https://bugs.webkit.org/show_bug.cgi?id=176615
<rdar://problem/34333067>

Reviewed by Chris Fleizach.

Source/WebCore:

Scrolling to make elements visible is not working correctly for elements inside an
offscreen iframe. Fixed it by using RenderLayer::scrollRectToVisible() to handle
scrolling more properly.

Test: accessibility/scroll-to-make-visible-iframe-offscreen.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollToMakeVisible const):

LayoutTests:

• accessibility/resources/iframe.html: Added.
• accessibility/scroll-to-make-visible-iframe-offscreen-expected.txt: Added.
• accessibility/scroll-to-make-visible-iframe-offscreen.html: Added.
• platform/win/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/resources/iframe.html (added)
• LayoutTests/accessibility/scroll-to-make-visible-iframe-offscreen-expected.txt (added)
• LayoutTests/accessibility/scroll-to-make-visible-iframe-offscreen.html (added)
• LayoutTests/platform/win/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-09  Nan Wang  <n_wang@apple.com>
+
+        AX: VoiceOver iframe scrolling focus jumping bug
+        https://bugs.webkit.org/show_bug.cgi?id=176615
+        <rdar://problem/34333067>
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/resources/iframe.html: Added.
+        * accessibility/scroll-to-make-visible-iframe-offscreen-expected.txt: Added.
+        * accessibility/scroll-to-make-visible-iframe-offscreen.html: Added.
+        * platform/win/TestExpectations:
+
 2018-05-09  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/LayoutTests/platform/win/TestExpectations

@@ -1575 +1575 @@
 accessibility/scroll-to-make-visible-nested.html [ Skip ]
 accessibility/scroll-to-make-visible-with-subfocus.html [ Skip ]
+accessibility/scroll-to-make-visible-iframe-offscreen.html [ Skip ]
 
 # Apparently missing support for roleDescription on Windows.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-05-09  Nan Wang  <n_wang@apple.com>
+
+        AX: VoiceOver iframe scrolling focus jumping bug
+        https://bugs.webkit.org/show_bug.cgi?id=176615
+        <rdar://problem/34333067>
+
+        Reviewed by Chris Fleizach.
+
+        Scrolling to make elements visible is not working correctly for elements inside an
+        offscreen iframe. Fixed it by using RenderLayer::scrollRectToVisible() to handle
+        scrolling more properly.
+
+        Test: accessibility/scroll-to-make-visible-iframe-offscreen.html
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::scrollToMakeVisible const):
+
 2018-05-09  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -2982 +2982 @@
     if (dispatchAccessibilityEventWithType(AccessibilityEventType::ScrollIntoView))
         return;
-    IntRect objectRect = snappedIntRect(boundingBoxRect());
-    objectRect.setLocation(IntPoint());
-    scrollToMakeVisibleWithSubFocus(objectRect);
+    
+    if (isScrollView() && parentObject())
+        parentObject()->scrollToMakeVisible();
+
+    if (auto* renderer = this->renderer())
+        renderer->scrollRectToVisible(SelectionRevealMode::Reveal, boundingBoxRect(), false, ScrollAlignment::alignCenterIfNotVisible, ScrollAlignment::alignCenterIfNotVisible);
 }