Changeset 231635 in webkit


Ignore:
Timestamp:
May 10, 2018 12:15:42 AM (6 years ago)
Author:
Fujii Hironori
Message:

REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
https://bugs.webkit.org/show_bug.cgi?id=185505

Unreviewed serious crash fix

Windows port crashes soon since Bug 184996.

  • WebPreferences.cpp:

(WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.

  • WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
Location:
trunk/Source/WebKitLegacy/win
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKitLegacy/win/ChangeLog

    r231442 r231635  
     12018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
     4        https://bugs.webkit.org/show_bug.cgi?id=185505
     5
     6        Unreviewed serious crash fix
     7
     8        Windows port crashes soon since Bug 184996.
     9
     10        * WebPreferences.cpp:
     11        (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
     12        * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
     13
    1142018-05-07  Daniel Bates  <dabates@apple.com>
    215
  • trunk/Source/WebKitLegacy/win/WebPreferences.cpp

    r231622 r231635  
    577577    else if (IsEqualGUID(riid, IID_IWebPreferencesPrivate6))
    578578        *ppvObject = static_cast<IWebPreferencesPrivate6*>(this);
     579    else if (IsEqualGUID(riid, IID_IWebPreferencesPrivate7))
     580        *ppvObject = static_cast<IWebPreferencesPrivate7*>(this);
    579581    else if (IsEqualGUID(riid, CLSID_WebPreferences))
    580582        *ppvObject = this;
  • trunk/Source/WebKitLegacy/win/WebPreferences.h

    r231622 r231635  
    3131#include <wtf/RetainPtr.h>
    3232
    33 class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate6 {
     33class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate7 {
    3434public:
    3535    static WebPreferences* createInstance();
Note: See TracChangeset for help on using the changeset viewer.