Changeset 231720 in webkit
- Timestamp:
- May 11, 2018 2:58:19 PM (6 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r231717 r231720 1 2018-05-11 Nan Wang <n_wang@apple.com> 2 3 AX: In role=dialog elements with aria-modal=true VoiceOver iOS/macOS can't manually focus or read dialog paragraph description text inside the modal. 4 https://bugs.webkit.org/show_bug.cgi?id=185219 5 <rdar://problem/39920009> 6 7 Reviewed by Chris Fleizach. 8 9 * accessibility/aria-modal-text-descendants-expected.txt: Added. 10 * accessibility/aria-modal-text-descendants.html: Added. 11 1 12 2018-05-11 Ryosuke Niwa <rniwa@webkit.org> 2 13 -
trunk/Source/WebCore/ChangeLog
r231717 r231720 1 2018-05-11 Nan Wang <n_wang@apple.com> 2 3 AX: In role=dialog elements with aria-modal=true VoiceOver iOS/macOS can't manually focus or read dialog paragraph description text inside the modal. 4 https://bugs.webkit.org/show_bug.cgi?id=185219 5 <rdar://problem/39920009> 6 7 Reviewed by Chris Fleizach. 8 9 The text node descendants of a modal dialog are ignored. Fixed it by using AccessibilityObject's 10 node() to determine if it's the descendant of the modal dialog node. 11 12 Test: accessibility/aria-modal-text-descendants.html 13 14 * accessibility/AccessibilityObject.cpp: 15 (WebCore::AccessibilityObject::isModalDescendant const): 16 1 17 2018-05-11 Ryosuke Niwa <rniwa@webkit.org> 2 18 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r231628 r231720 2089 2089 bool AccessibilityObject::isModalDescendant(Node* modalNode) const 2090 2090 { 2091 if (!modalNode || !this->element()) 2092 return false; 2093 2094 if (this->element() == modalNode) 2091 Node* node = this->node(); 2092 if (!modalNode || !node) 2093 return false; 2094 2095 if (node == modalNode) 2095 2096 return true; 2096 2097 2097 2098 // ARIA 1.1 aria-modal, indicates whether an element is modal when displayed. 2098 2099 // For the decendants of the modal object, they should also be considered as aria-modal=true. 2099 for (auto& ancestor : elementAncestors(this->element())) { 2100 if (&ancestor == modalNode) 2101 return true; 2102 } 2103 return false; 2100 return node->isDescendantOf(*modalNode); 2104 2101 } 2105 2102
Note: See TracChangeset
for help on using the changeset viewer.