Changeset 231821 in webkit

Timestamp:

May 15, 2018 4:50:19 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Update touch event tracking type on every touch
​https://bugs.webkit.org/show_bug.cgi?id=184250
<rdar://problem/39145092>

Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-05-15
Reviewed by Geoffrey Garen.

The tracking type for touch events were only update on touchstart, which meant that event
listeners added after the touchstart would always be treated as passive, even if explicitly
setting passive to false.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::handleTouchEvent):

LayoutTests:

• fast/events/touch/ios/touchmove-cancelable-after-touchstart-expected.txt: Added.
• fast/events/touch/ios/touchmove-cancelable-after-touchstart.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/touchmove-cancelable-after-touchstart-expected.txt (added)
• LayoutTests/fast/events/touch/ios/touchmove-cancelable-after-touchstart.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/WebPageProxy.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-15  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Update touch event tracking type on every touch
+        https://bugs.webkit.org/show_bug.cgi?id=184250
+        <rdar://problem/39145092>
+
+        Reviewed by Geoffrey Garen.
+
+        The tracking type for touch events were only update on touchstart, which meant that event
+        listeners added after the touchstart would always be treated as passive, even if explicitly
+        setting passive to false.
+
+        * fast/events/touch/ios/touchmove-cancelable-after-touchstart-expected.txt: Added.
+        * fast/events/touch/ios/touchmove-cancelable-after-touchstart.html: Added.
+
 2018-05-15  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-05-15  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Update touch event tracking type on every touch
+        https://bugs.webkit.org/show_bug.cgi?id=184250
+        <rdar://problem/39145092>
+
+        Reviewed by Geoffrey Garen.
+
+        The tracking type for touch events were only update on touchstart, which meant that event
+        listeners added after the touchstart would always be treated as passive, even if explicitly
+        setting passive to false.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::handleTouchEventSynchronously):
+        (WebKit::WebPageProxy::handleTouchEvent):
+
 2018-05-15  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -2301 +2301 @@
     TraceScope scope(SyncTouchEventStart, SyncTouchEventEnd);
 
-    if (event.type() == WebEvent::TouchStart)
-        updateTouchEventTracking(event);
+    updateTouchEventTracking(event);
 
     TrackingType touchEventsTrackingType = touchEventTrackingType(event);
@@ -2356 +2355 @@
         return;
 
-    if (event.type() == WebEvent::TouchStart)
-        updateTouchEventTracking(event);
+    updateTouchEventTracking(event);
 
     if (touchEventTrackingType(event) == TrackingType::NotTracking)