Changeset 231874 in webkit

Timestamp:

May 16, 2018 3:15:49 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Test262-Runner: Adds a --timeout option
​https://bugs.webkit.org/show_bug.cgi?id=185696

Patch by Leo Balter <Leo Balter> on 2018-05-16
Reviewed by Michael Saboff.

The timeout option is used to set a timeout execution in ms for each test run in JSC.
The passed value - if defined - will be used as the value for the JSC --watchdog arg.

• Scripts/test262/Runner.pm:

(processCLI):
(runTest):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/test262/Runner.pm (modified) (5 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
+
+        Test262-Runner: Adds a --timeout option
+        https://bugs.webkit.org/show_bug.cgi?id=185696
+
+        Reviewed by Michael Saboff.
+
+        The timeout option is used to set a timeout execution in ms for each test run in JSC.
+        The passed value - if defined - will be used as the value for the JSC --watchdog arg.
+        * Scripts/test262/Runner.pm:
+        (processCLI):
+        (runTest):
+
 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
 

trunk/Tools/Scripts/test262/Runner.pm

@@ -84 +84 @@
 my $latestImport;
 my $runningAllTests;
+my $timeout;
 
 my $expectationsFile = abs_path("$Bin/../../../JSTests/test262/expectations.yaml");
@@ -136 +137 @@
         'stats' => \$stats,
         'r|results=s' => \$specifiedResultsFile,
+        'timeout=i' => \$timeout,
     );
 
@@ -235 +237 @@
         . "Child Processes: $max_process\n";
 
+    print "Test timeout: $timeout\n" if $timeout;
     print "Features to include: " . join(', ', @features) . "\n" if @features;
-    print "Paths:  " . join(', ', @cliTestDirs) . "\n" if @cliTestDirs;
+    print "Paths: " . join(', ', @cliTestDirs) . "\n" if @cliTestDirs;
     print "Config file: $configFile\n" if $config;
     print "Expectations file: $expectationsFile\n" if $expect;
@@ -598 +601 @@
     my $args = '';
 
+    if ($timeout) {
+        $args .= " --watchdog=$timeout ";
+    }
+
     if (exists $data->{negative}) {
         my $type = $data->{negative}->{type};
@@ -958 +965 @@
 Specifies a results file for the --stats or --failing-files options.
 
+=item B<--timeout>
+
+Specifies a timeout execution in ms for each test. Defers the value to the jsc --watchdog argument. Disabled by default.
+
 =back