Changeset 231923 in webkit

Timestamp:

May 17, 2018 3:15:06 PM (6 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r231899.

Caused flakiness in two existing modern-media-controls tests.

Reverted changeset:

"[modern-media-controls] AirPlaySupport should be disabled by
default"
​https://bugs.webkit.org/show_bug.cgi?id=185658
​https://trac.webkit.org/changeset/231899

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/modern-media-controls/airplay-support/airplay-support-disable-event-listeners-until-play-expected.txt (deleted)
• LayoutTests/media/modern-media-controls/airplay-support/airplay-support-disable-event-listeners-until-play.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/modern-media-controls/media/airplay-support.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-17  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r231899.
+
+        Caused flakiness in two existing modern-media-controls tests.
+
+        Reverted changeset:
+
+        "[modern-media-controls] AirPlaySupport should be disabled by
+        default"
+        https://bugs.webkit.org/show_bug.cgi?id=185658
+        https://trac.webkit.org/changeset/231899
+
 2018-05-17  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-05-17  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r231899.
+
+        Caused flakiness in two existing modern-media-controls tests.
+
+        Reverted changeset:
+
+        "[modern-media-controls] AirPlaySupport should be disabled by
+        default"
+        https://bugs.webkit.org/show_bug.cgi?id=185658
+        https://trac.webkit.org/changeset/231899
+
 2018-05-17  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/media/airplay-support.js

@@ -39 +39 @@
     }
 
-    enable()
-    {
-        if (this._shouldBeEnabled())
-            super.enable();
-    }
-
     buttonWasPressed(control)
     {
@@ -52 +46 @@
     controlsUserVisibilityDidChange()
     {
-        if (this._shouldBeEnabled())
+        const controls = this.mediaController.controls;
+        if (controls.visible && !controls.faded)
             this.enable();
         else
@@ -73 +68 @@
     }
 
-    // Private
-
-    _shouldBeEnabled()
-    {
-        if (!this.mediaController.hasPlayed)
-            return false;
-
-        const controls = this.mediaController.controls;
-        return controls.visible && !controls.faded;
-    }
-
 }