Changeset 231938 in webkit

Timestamp:

May 17, 2018 6:41:58 PM (6 years ago)

Author:

sbarati@apple.com

Message:

Remove shrinkFootprint test from apitests since it's flaky
​https://bugs.webkit.org/show_bug.cgi?id=185754

Reviewed by Mark Lam.

This test is flaky as it keeps failing on certain people's machines.
Having a test about OS footprint seems like it'll forever be doomed
to being flaky.

• API/tests/testapi.mm:

(testObjectiveCAPIMain):

Location:

trunk/Source/JavaScriptCore

Files:

• API/tests/testapi.mm (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/tests/testapi.mm

@@ -1473 +1473 @@
     }
 
-    @autoreleasepool {
-        JSContext *context = [[JSContext alloc] init];
-        JSVirtualMachine *vm = [context virtualMachine];
-        [vm shrinkFootprint]; // Make sure that when we allocate a ton of memory below we reuse at little as possible.
-
-        std::optional<size_t> footprintBefore = WTF::memoryFootprint();
-        RELEASE_ASSERT(footprintBefore);
-
-        [context evaluateScript:@"for (let i = 0; i < 10000; ++i) { eval(`myVariable_${i} = [i]`); }"];
-
-        static constexpr size_t approximateBytes = 10000 * sizeof(int);
-        std::optional<size_t> footprintMiddle = WTF::memoryFootprint();
-        RELEASE_ASSERT(footprintMiddle);
-        checkResult(@"Footprint is larger than what we allocated", *footprintMiddle > approximateBytes);
-        checkResult(@"Footprint got larger as we allocated a ton of stuff", *footprintMiddle > *footprintBefore);
-        size_t allocationDelta = *footprintMiddle - *footprintBefore;
-        checkResult(@"We allocated as much or more memory than what we expected to", allocationDelta >= approximateBytes);
-
-        [context evaluateScript:@"for (let i = 0; i < 10000; ++i) { eval(`myVariable_${i} = null`); }"];
-        [vm shrinkFootprint];
-        std::optional<size_t> footprintAfter = WTF::memoryFootprint();
-        RELEASE_ASSERT(footprintAfter);
-        checkResult(@"Footprint got smaller after we shrank the VM", *footprintAfter < *footprintMiddle);
-        size_t freeDelta = *footprintMiddle - *footprintAfter;
-        checkResult(@"Shrinking the footprint of the VM actually freed memory", freeDelta > (approximateBytes / 2));
-    }
-
     currentThisInsideBlockGetterTest();
     runDateTests();

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-05-17  Saam Barati  <sbarati@apple.com>
+
+        Remove shrinkFootprint test from apitests since it's flaky
+        https://bugs.webkit.org/show_bug.cgi?id=185754
+
+        Reviewed by Mark Lam.
+
+        This test is flaky as it keeps failing on certain people's machines.
+        Having a test about OS footprint seems like it'll forever be doomed
+        to being flaky.
+
+        * API/tests/testapi.mm:
+        (testObjectiveCAPIMain):
+
 2018-05-17  Saam Barati  <sbarati@apple.com>