Changeset 232015 in webkit

Timestamp:

May 21, 2018 8:28:28 AM (6 years ago)

Author:

aboya@igalia.com

Message:

[MSE][GStreamer] Stream::decodebinSinkPad is read but never assigned
​https://bugs.webkit.org/show_bug.cgi?id=185724

Reviewed by Xabier Rodriguez-Calvar.

This is a dead code removal patch; except when a Stream instance
happens to be instantiated in such a place that the non-initialized
decodeSinkPad is != 0, then it is a crash bug fix.

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcLinkStreamToSrcPad):

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp (modified) (1 diff)
• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-05-21  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Stream::decodebinSinkPad is read but never assigned
+        https://bugs.webkit.org/show_bug.cgi?id=185724
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        This is a dead code removal patch; except when a Stream instance
+        happens to be instantiated in such a place that the non-initialized
+        decodeSinkPad is != 0, then it is a crash bug fix.
+
+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
+        (webKitMediaSrcLinkStreamToSrcPad):
+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h:
+
 2018-05-21  Alicia Boya García  <aboya@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

@@ -479 +479 @@
     gst_pad_set_active(ghostpad, TRUE);
     gst_element_add_pad(GST_ELEMENT(stream->parent), ghostpad);
-
-    if (stream->decodebinSinkPad) {
-        GST_DEBUG_OBJECT(stream->parent, "A decodebin was previously used for this source, trying to reuse it.");
-        // FIXME: error checking here. Not sure what to do if linking
-        // fails though, because decodebin is out of this source
-        // element's scope, in theory.
-        gst_pad_link(ghostpad, stream->decodebinSinkPad);
-    }
 }
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h

@@ -52 +52 @@
     // AppSrc. Never modified after first assignment.
     GstElement* appsrc;
-    GstPad* decodebinSinkPad;
 
     // Never modified after first assignment.