Changeset 232024 in webkit


Ignore:
Timestamp:
May 21, 2018 1:50:46 PM (6 years ago)
Author:
jer.noble@apple.com
Message:

Complete fix for enabling modern EME by default
​https://bugs.webkit.org/show_bug.cgi?id=185770
<rdar://problem/40368220>

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt:
Location:
trunk
Files:
15 edited
1 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r232005 r232024  
     12018-05-21  Jer Noble  <jer.noble@apple.com>
     2
     3        Complete fix for enabling modern EME by default
     4        https://bugs.webkit.org/show_bug.cgi?id=185770
     5        <rdar://problem/40368220>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * platform/mac/TestExpectations:
     10        * platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
     11        * platform/mac/fast/dom/navigator-detached-no-crash-expected.txt:
     12
    1132018-05-20  Emilio Cobos Álvarez  <emilio@crisal.io>
    214

  • trunk/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt

    r231993 r232024  
    1 CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Not enough arguments
    21This tests that the navigator object of a deleted frame is disconnected properly. Accessing fields or methods shouldn't crash the browser.
    32 Check Navigator
    … …  
    1817navigator.product is OK
    1918navigator.productSub is OK
    20 navigator.requestMediaKeySystemAccess() is OK
    2119navigator.userAgent is OK
    2220navigator.vendor is OK
    … …  
    3937navigator.product is OK
    4038navigator.productSub is OK
    41 navigator.requestMediaKeySystemAccess() is OK
    4239navigator.userAgent is OK
    4340navigator.vendor is OK

  • trunk/LayoutTests/platform/mac/TestExpectations

    r231867 r232024  
    17691769# macOS doesn't have ICU v59
    17701770webkit.org/b/185375 js/intl-numberformat-format-to-parts.html [ Failure ]
     1771
     1772# <= High Sierra doesn't support Modern EME
     1773[ HighSierra ] platform/mac/media/encrypted-media/fps-createMediaKeys.html [ Skip ]
     1774[ HighSierra ] platform/mac/media/encrypted-media/fps-createSession.html [ Skip ]
     1775[ HighSierra ] platform/mac/media/encrypted-media/fps-encrypted-event.html [ Skip ]
     1776[ HighSierra ] platform/mac/media/encrypted-media/fps-generateRequest.html [ Skip ]
     1777[ HighSierra ] platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess.html [ Skip ]

  • trunk/LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt

    r232023 r232024  
    1 CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Not enough arguments
    21This tests that the navigator object of a deleted frame is disconnected properly. Accessing fields or methods shouldn't crash the browser.
    32 Check Navigator
    … …  
    1817navigator.product is OK
    1918navigator.productSub is OK
    20 navigator.requestMediaKeySystemAccess() is OK
     19navigator.sendBeacon() threw err TypeError: Not enough arguments
     20navigator.serviceWorker is OK
    2121navigator.userAgent is OK
    2222navigator.vendor is OK
    … …  
    3939navigator.product is OK
    4040navigator.productSub is OK
    41 navigator.requestMediaKeySystemAccess() is OK
     41navigator.sendBeacon() threw err TypeError: Not enough arguments
     42navigator.serviceWorker is OK
    4243navigator.userAgent is OK
    4344navigator.vendor is OK

  • trunk/Source/JavaScriptCore/ChangeLog

    r232017 r232024  
     12018-05-21  Jer Noble  <jer.noble@apple.com>
     2
     3        Complete fix for enabling modern EME by default
     4        https://bugs.webkit.org/show_bug.cgi?id=185770
     5        <rdar://problem/40368220>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
    212

  • trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r231993 r232024  
    123123ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
    124124ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
    125 ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
     125ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
     126ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
    126127
    127128ENABLE_EXTRA_ZOOM_MODE = ;

  • trunk/Source/WebCore/ChangeLog

    r232023 r232024  
     12018-05-21  Jer Noble  <jer.noble@apple.com>
     2
     3        Complete fix for enabling modern EME by default
     4        https://bugs.webkit.org/show_bug.cgi?id=185770
     5        <rdar://problem/40368220>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112018-05-21  Olivier Blin  <olivier.blin@softathome.com>
    212

  • trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r231993 r232024  
    123123ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
    124124ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
    125 ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
     125ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
     126ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
    126127
    127128ENABLE_EXTRA_ZOOM_MODE = ;

  • trunk/Source/WebCore/PAL/ChangeLog

    r231993 r232024  
     12018-05-21  Jer Noble  <jer.noble@apple.com>
     2
     3        Complete fix for enabling modern EME by default
     4        https://bugs.webkit.org/show_bug.cgi?id=185770
     5        <rdar://problem/40368220>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112018-05-18  Commit Queue  <commit-queue@webkit.org>
    212

  • trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig

    r231993 r232024  
    123123ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
    124124ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
    125 ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
     125ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
     126ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
    126127
    127128ENABLE_EXTRA_ZOOM_MODE = ;

  • trunk/Source/WebKit/ChangeLog

    r232018 r232024  
     12018-05-21  Jer Noble  <jer.noble@apple.com>
     2
     3        Complete fix for enabling modern EME by default
     4        https://bugs.webkit.org/show_bug.cgi?id=185770
     5        <rdar://problem/40368220>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112018-05-21  Sam Weinig  <sam@webkit.org>
    212

  • trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig

    r231993 r232024  
    123123ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
    124124ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
    125 ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
     125ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
     126ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
    126127
    127128ENABLE_EXTRA_ZOOM_MODE = ;

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r232016 r232024  
     12018-05-21  Jer Noble  <jer.noble@apple.com>
     2
     3        Complete fix for enabling modern EME by default
     4        https://bugs.webkit.org/show_bug.cgi?id=185770
     5        <rdar://problem/40368220>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112018-05-21  Antti Koivisto  <antti@apple.com>
    212

  • trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig

    r231993 r232024  
    123123ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
    124124ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
    125 ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
     125ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
     126ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
    126127
    127128ENABLE_EXTRA_ZOOM_MODE = ;

  • trunk/Tools/ChangeLog

    r232021 r232024  
     12018-05-21  Jer Noble  <jer.noble@apple.com>
     2
     3        Complete fix for enabling modern EME by default
     4        https://bugs.webkit.org/show_bug.cgi?id=185770
     5        <rdar://problem/40368220>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     10
    1112018-05-18  Christopher Reid  <chris.reid@sony.com>
    212

  • trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

    r231993 r232024  
    123123ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
    124124ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
    125 ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
     125ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
     126ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
    126127
    127128ENABLE_EXTRA_ZOOM_MODE = ;
Note: See TracChangeset for help on using the changeset viewer.