Changeset 232026 in webkit


Ignore:
Timestamp:
May 21, 2018 2:28:16 PM (6 years ago)
Author:
eric.carlson@apple.com
Message:

Improve NowPlaying "title"
​https://bugs.webkit.org/show_bug.cgi?id=185680
<rdar://problem/40296700>

Unreviewed test fix.

  • http/tests/media/now-playing-info-expected.txt:
  • http/tests/media/now-playing-info.html: Don't test .elapsedTime before seeking because

the time value can take a while to "settle" when a file has just loaded.

Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r232024 r232026  
     12018-05-21  Eric Carlson  <eric.carlson@apple.com>
     2
     3        Improve NowPlaying "title"
     4        https://bugs.webkit.org/show_bug.cgi?id=185680
     5        <rdar://problem/40296700>
     6
     7        Unreviewed test fix.
     8
     9        * http/tests/media/now-playing-info-expected.txt:
     10        * http/tests/media/now-playing-info.html: Don't test .elapsedTime before seeking because
     11        the time value can take a while to "settle" when a file has just loaded.
     12
    1132018-05-21  Jer Noble  <jer.noble@apple.com>
    214

  • trunk/LayoutTests/http/tests/media/now-playing-info-expected.txt

    r231866 r232026  
    1818EXPECTED (nowPlayingState.title == 'Page Title') OK
    1919EXPECTED (nowPlayingState.duration > '0') OK
    20 EXPECTED (nowPlayingState.elapsedTime >= '0') OK
    2120
    2221* Set video title, it should be used.

  • trunk/LayoutTests/http/tests/media/now-playing-info.html

    r231866 r232026  
    4848                testExpected('nowPlayingState.title', 'Page Title');
    4949                testExpected('nowPlayingState.duration', '0', '>');
    50                 testExpected('nowPlayingState.elapsedTime', '0', '>=');
    5150                previousNowPlayingState = nowPlayingState;
    5251
    … …  
    6564                if (nowPlayingState.uniqueIdentifier != previousNowPlayingState.uniqueIdentifier)
    6665                    testExpected('nowPlayingState.uniqueIdentifier', previousNowPlayingState.uniqueIdentifier);
    67                 if (nowPlayingState.elapsedTime != previousNowPlayingState.elapsedTime)
    68                     testExpected('nowPlayingState.elapsedTime', previousNowPlayingState.elapsedTime);
    6966                previousNowPlayingState = nowPlayingState;
    7067
    … …  
    8077                if (nowPlayingState.uniqueIdentifier != previousNowPlayingState.uniqueIdentifier)
    8178                    testExpected('nowPlayingState.uniqueIdentifier', previousNowPlayingState.uniqueIdentifier);
    82                 if (nowPlayingState.elapsedTime != previousNowPlayingState.elapsedTime)
    83                     testExpected('nowPlayingState.elapsedTime', previousNowPlayingState.elapsedTime);
    8479                previousNowPlayingState = nowPlayingState;
    8580
Note: See TracChangeset for help on using the changeset viewer.