Changeset 232039 in webkit
- Timestamp:
- May 21, 2018 5:14:39 PM (6 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r232037 r232039 1 2018-05-21 Basuke Suzuki <Basuke.Suzuki@sony.com> 2 3 [Curl] Bugfix for r231968, Suspend/Resume with WK2 4 https://bugs.webkit.org/show_bug.cgi?id=185830 5 6 The flags are needed to be updated even if it is cancelled or finished to cleanup correctly. 7 Also fixed trivial bug for very rare case (hard to produce the situation). 8 9 Reviewed by Youenn Fablet. 10 11 No new tests because WK2 is not ready for WinCairo yet in public., tested internaly. 12 13 * platform/network/curl/CurlRequest.cpp: 14 (WebCore::CurlRequest::suspend): 15 (WebCore::CurlRequest::resume): 16 (WebCore::CurlRequest::pausedStatusChanged): 17 1 18 2018-05-21 Commit Queue <commit-queue@webkit.org> 2 19 -
trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
r231968 r232039 133 133 ASSERT(isMainThread()); 134 134 135 if (isCompletedOrCancelled())136 return;137 138 135 setRequestPaused(true); 139 136 } … … 142 139 { 143 140 ASSERT(isMainThread()); 144 145 if (isCompletedOrCancelled())146 return;147 141 148 142 setRequestPaused(false); … … 649 643 void CurlRequest::pausedStatusChanged() 650 644 { 645 if (isCompletedOrCancelled()) 646 return; 647 651 648 runOnWorkerThreadIfRequired([this, protectedThis = makeRef(*this)]() { 652 649 if (isCompletedOrCancelled()) … … 665 662 updateHandlePauseState(paused); 666 663 667 needCancel = (error != CURLE_OK && paused);664 needCancel = (error != CURLE_OK && !paused); 668 665 } 669 666
Note: See TracChangeset
for help on using the changeset viewer.