Changeset 232046 in webkit

Timestamp:

May 21, 2018 9:04:17 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

Remove unused and no-op WKContextSetCookieStorageDirectory
​https://bugs.webkit.org/show_bug.cgi?id=185857

Reviewed by Youenn Fablet.

Deleted C API which didn't do anything useful, and consequently not used by anyone.

• UIProcess/API/C/WKContext.cpp:

(WKContextSetCookieStorageDirectory): Deleted.

• UIProcess/API/C/WKContextPrivate.h:
• UIProcess/WebProcessPool.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/C/WKContext.cpp (modified) (1 diff)
• UIProcess/API/C/WKContextPrivate.h (modified) (1 diff)
• UIProcess/WebProcessPool.h (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-05-21  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Remove unused and no-op WKContextSetCookieStorageDirectory
+        https://bugs.webkit.org/show_bug.cgi?id=185857
+
+        Reviewed by Youenn Fablet.
+
+        Deleted C API which didn't do anything useful, and consequently not used by anyone.
+
+        * UIProcess/API/C/WKContext.cpp:
+        (WKContextSetCookieStorageDirectory): Deleted.
+        * UIProcess/API/C/WKContextPrivate.h:
+        * UIProcess/WebProcessPool.h:
+
 2018-05-21  Chris Nardi  <cnardi@chromium.org>
 

trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp

@@ -489 +489 @@
 }
 
-WK_EXPORT void WKContextSetCookieStorageDirectory(WKContextRef contextRef, WKStringRef cookieStorageDirectory)
-{
-    toImpl(contextRef)->setCookieStorageDirectory(toImpl(cookieStorageDirectory)->string());
-}
-
 void WKContextDisableProcessTermination(WKContextRef contextRef)
 {

trunk/Source/WebKit/UIProcess/API/C/WKContextPrivate.h

@@ -76 +76 @@
 WK_EXPORT void WKContextAllowSpecificHTTPSCertificateForHost(WKContextRef context, WKCertificateInfoRef certificate, WKStringRef host);
 
-WK_EXPORT void WKContextSetCookieStorageDirectory(WKContextRef context, WKStringRef cookieStorageDirectory);
-
 // FIXME: This is a workaround for testing purposes only and should be removed once a better
 // solution has been found for testing.

trunk/Source/WebKit/UIProcess/WebProcessPool.h

@@ -262 +262 @@
     static Statistics& statistics();    
 
-    void setCookieStorageDirectory(const String& dir) { m_overrideCookieStorageDirectory = dir; }
-
     void useTestingNetworkSession();
     bool isUsingTestingNetworkSession() const { return m_shouldUseTestingNetworkSession; }
@@ -615 +613 @@
 #endif
 
-    String m_overrideCookieStorageDirectory;
-
     bool m_shouldUseTestingNetworkSession { false };