Changeset 232058 in webkit
- Timestamp:
- May 22, 2018 2:32:46 AM (6 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r232052 r232058 1 2018-05-22 Yacine Bandou <yacine.bandou_ext@softathome.com> 2 3 [MSE][GStreamer] Fix the deadlock caused by bug 185242 (r231351) 4 https://bugs.webkit.org/show_bug.cgi?id=185723 5 6 Reviewed by Xabier Rodriguez-Calvar. 7 8 After a detailed investigation, we found that, the patch r231351 doesn't fix the crash that expected to fix, 9 it just replaces it by a deadlock. Now the crash is fixed in the bug 185725. 10 11 This Patch will remove a part of r231351 that causes the deadlock. 12 13 * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp: 14 (webKitMediaSrcFreeStream): 15 1 16 2018-05-21 Yusuke Suzuki <utatane.tea@gmail.com> 2 17 -
trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
r232015 r232058 506 506 gst_app_src_set_callbacks(GST_APP_SRC(stream->appsrc), &disabledAppsrcCallbacks, nullptr, nullptr); 507 507 gst_app_src_end_of_stream(GST_APP_SRC(stream->appsrc)); 508 gst_element_set_state(stream->appsrc, GST_STATE_NULL);509 gst_bin_remove(GST_BIN(source), stream->appsrc);510 stream->appsrc = nullptr;511 }512 513 if (stream->parser) {514 gst_element_set_state(stream->parser, GST_STATE_NULL);515 gst_bin_remove(GST_BIN(source), stream->parser);516 stream->parser = nullptr;517 508 } 518 509
Note: See TracChangeset
for help on using the changeset viewer.