Changeset 232088 in webkit

Timestamp:

May 22, 2018 4:54:04 PM (6 years ago)

Author:

Chris Dumez

Message:

[POSIX] Use access() instead of stat() in FileSystem::fileExists()
​https://bugs.webkit.org/show_bug.cgi?id=185882

Reviewed by Geoffrey Garen.

Use access() instead of stat() in FileSystem::fileExists(). stat() returns a lot of information we
do not leverage and local benchmarking on macOS shows access() being > 80% faster than stat():
stat: 0.31567 (lower is better)
access: 0.16074 (lower is better)
stat: 0.303665 (lower is better)
access: 0.165468 (lower is better)

• platform/posix/FileSystemPOSIX.cpp:

(WebCore::FileSystem::fileExists):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/posix/FileSystemPOSIX.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-05-22  Chris Dumez  <cdumez@apple.com>
+
+        [POSIX] Use access() instead of stat() in FileSystem::fileExists()
+        https://bugs.webkit.org/show_bug.cgi?id=185882
+
+        Reviewed by Geoffrey Garen.
+
+        Use access() instead of stat() in FileSystem::fileExists(). stat() returns a lot of information we
+        do not leverage and local benchmarking on macOS shows access() being > 80% faster than stat():
+        stat: 0.31567 (lower is better)
+        access: 0.16074 (lower is better)
+        stat: 0.303665 (lower is better)
+        access: 0.165468 (lower is better)
+
+        * platform/posix/FileSystemPOSIX.cpp:
+        (WebCore::FileSystem::fileExists):
+
 2018-05-22  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp

@@ -59 +59 @@
         return false;
 
-    struct stat fileInfo;
-
-    // stat(...) returns 0 on successful stat'ing of the file, and non-zero in any case where the file doesn't exist or cannot be accessed
-    return !stat(fsRep.data(), &fileInfo);
+    return access(fsRep.data(), F_OK) != -1;
 }