Changeset 232144 in webkit

Timestamp:

May 23, 2018 9:08:43 PM (6 years ago)

Author:

Chris Dumez

Message:

Regression(r229831): fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=183885
<rdar://problem/38733968>

Reviewed by Youenn Fablet.

Stop loading an external URL as this is not what the test is testing and since the error message for
the external load causes flakiness.

• TestExpectations:
• fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt:
• fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html:
• fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt:
• fast/loader/javascript-url-iframe-remove-on-navigate.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (1 diff)
• fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt (modified) (1 diff)
• fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html (modified) (1 diff)
• fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt (modified) (1 diff)
• fast/loader/javascript-url-iframe-remove-on-navigate.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-23  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r229831): fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=183885
+        <rdar://problem/38733968>
+
+        Reviewed by Youenn Fablet.
+
+        Stop loading an external URL as this is not what the test is testing and since the error message for
+        the external load causes flakiness.
+
+        * TestExpectations:
+        * fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt:
+        * fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html:
+        * fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt:
+        * fast/loader/javascript-url-iframe-remove-on-navigate.html:
+
 2018-05-23  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -1977 +1977 @@
 media/event-queue-crash.html [ DumpJSConsoleLogInStdErr ]
 
-# This is flaky since r229831.
-webkit.org/b/183885 fast/loader/javascript-url-iframe-remove-on-navigate.html [ Pass Failure ]
-webkit.org/b/183885 fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html [ Pass Failure ]
-
 webkit.org/b/172243 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm [ Pass Failure ]
 

trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt

@@ -1 @@
-Blocked access to external URL http://does.not.exist/
 PASS - Javascript URL blocked without crashing.

trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html

@@ -1 @@
-<iframe src="http://does.not.exist/" id="target"></iframe>
+<iframe src="resources/empty-subframe.html" id="target"></iframe>
 <script>
 if (window.testRunner) {

trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt

@@ -1 @@
-Blocked access to external URL http://does.not.exist/
 PASS - Javascript URL blocked without crashing.

trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate.html

@@ -1 @@
-<iframe src="http://does.not.exist/" id="target"></iframe>
+<iframe src="resources/empty-subframe.html" id="target"></iframe>
 <script>
 if (window.testRunner) {