Changeset 232148 in webkit


Ignore:
Timestamp:
May 23, 2018 10:42:10 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Use ASCIILiteral with applicationBundleIsEqualTo in RuntimeApplicationChecksCocoa
​https://bugs.webkit.org/show_bug.cgi?id=185935

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-05-23
Reviewed by Yusuke Suzuki.

  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::MacApplication::isSafari):
(WebCore::MacApplication::isAppleMail):
(WebCore::MacApplication::isIBooks):
(WebCore::MacApplication::isITunes):
(WebCore::MacApplication::isMicrosoftMessenger):
(WebCore::MacApplication::isAdobeInstaller):
(WebCore::MacApplication::isAOLInstantMessenger):
(WebCore::MacApplication::isMicrosoftMyDay):
(WebCore::MacApplication::isMicrosoftOutlook):
(WebCore::MacApplication::isQuickenEssentials):
(WebCore::MacApplication::isAperture):
(WebCore::MacApplication::isVersions):
(WebCore::MacApplication::isHRBlock):
(WebCore::MacApplication::isIAdProducer):
(WebCore::MacApplication::isSolidStateNetworksDownloader):
(WebCore::IOSApplication::isMobileMail):
(WebCore::IOSApplication::isMobileSafari):
(WebCore::IOSApplication::isWebBookmarksD):
(WebCore::IOSApplication::isDumpRenderTree):
(WebCore::IOSApplication::isMobileStore):
(WebCore::IOSApplication::isSpringBoard):
(WebCore::IOSApplication::isWebApp):
(WebCore::IOSApplication::isIBooks):
(WebCore::IOSApplication::isIBooksStorytime):
(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
(WebCore::IOSApplication::isCardiogram):
(WebCore::IOSApplication::isNike):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r232147 r232148  
     12018-05-23  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Use ASCIILiteral with applicationBundleIsEqualTo in RuntimeApplicationChecksCocoa
     4        https://bugs.webkit.org/show_bug.cgi?id=185935
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
     9        (WebCore::MacApplication::isSafari):
     10        (WebCore::MacApplication::isAppleMail):
     11        (WebCore::MacApplication::isIBooks):
     12        (WebCore::MacApplication::isITunes):
     13        (WebCore::MacApplication::isMicrosoftMessenger):
     14        (WebCore::MacApplication::isAdobeInstaller):
     15        (WebCore::MacApplication::isAOLInstantMessenger):
     16        (WebCore::MacApplication::isMicrosoftMyDay):
     17        (WebCore::MacApplication::isMicrosoftOutlook):
     18        (WebCore::MacApplication::isQuickenEssentials):
     19        (WebCore::MacApplication::isAperture):
     20        (WebCore::MacApplication::isVersions):
     21        (WebCore::MacApplication::isHRBlock):
     22        (WebCore::MacApplication::isIAdProducer):
     23        (WebCore::MacApplication::isSolidStateNetworksDownloader):
     24        (WebCore::IOSApplication::isMobileMail):
     25        (WebCore::IOSApplication::isMobileSafari):
     26        (WebCore::IOSApplication::isWebBookmarksD):
     27        (WebCore::IOSApplication::isDumpRenderTree):
     28        (WebCore::IOSApplication::isMobileStore):
     29        (WebCore::IOSApplication::isSpringBoard):
     30        (WebCore::IOSApplication::isWebApp):
     31        (WebCore::IOSApplication::isIBooks):
     32        (WebCore::IOSApplication::isIBooksStorytime):
     33        (WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
     34        (WebCore::IOSApplication::isCardiogram):
     35        (WebCore::IOSApplication::isNike):
     36
    1372018-05-23  Brent Fulgham  <bfulgham@apple.com>
    238

  • trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

    r231130 r232148  
    8383bool MacApplication::isSafari()
    8484{
    85     static bool isSafari = applicationBundleIsEqualTo("com.apple.Safari") || applicationBundleIsEqualTo("com.apple.SafariTechnologyPreview");
     85    static bool isSafari = applicationBundleIsEqualTo(ASCIILiteral("com.apple.Safari")) || applicationBundleIsEqualTo(ASCIILiteral("com.apple.SafariTechnologyPreview"));
    8686    return isSafari;
    8787}
    … …  
    8989bool MacApplication::isAppleMail()
    9090{
    91     static bool isAppleMail = applicationBundleIsEqualTo("com.apple.mail");
     91    static bool isAppleMail = applicationBundleIsEqualTo(ASCIILiteral("com.apple.mail"));
    9292    return isAppleMail;
    9393}
    … …  
    9595bool MacApplication::isIBooks()
    9696{
    97     static bool isIBooks = applicationBundleIsEqualTo("com.apple.iBooksX");
     97    static bool isIBooks = applicationBundleIsEqualTo(ASCIILiteral("com.apple.iBooksX"));
    9898    return isIBooks;
    9999}
    … …  
    101101bool MacApplication::isITunes()
    102102{
    103     static bool isITunes = applicationBundleIsEqualTo("com.apple.iTunes");
     103    static bool isITunes = applicationBundleIsEqualTo(ASCIILiteral("com.apple.iTunes"));
    104104    return isITunes;
    105105}
    … …  
    107107bool MacApplication::isMicrosoftMessenger()
    108108{
    109     static bool isMicrosoftMessenger = applicationBundleIsEqualTo("com.microsoft.Messenger");
     109    static bool isMicrosoftMessenger = applicationBundleIsEqualTo(ASCIILiteral("com.microsoft.Messenger"));
    110110    return isMicrosoftMessenger;
    111111}
    … …  
    113113bool MacApplication::isAdobeInstaller()
    114114{
    115     static bool isAdobeInstaller = applicationBundleIsEqualTo("com.adobe.Installers.Setup");
     115    static bool isAdobeInstaller = applicationBundleIsEqualTo(ASCIILiteral("com.adobe.Installers.Setup"));
    116116    return isAdobeInstaller;
    117117}
    … …  
    119119bool MacApplication::isAOLInstantMessenger()
    120120{
    121     static bool isAOLInstantMessenger = applicationBundleIsEqualTo("com.aol.aim.desktop");
     121    static bool isAOLInstantMessenger = applicationBundleIsEqualTo(ASCIILiteral("com.aol.aim.desktop"));
    122122    return isAOLInstantMessenger;
    123123}
    … …  
    125125bool MacApplication::isMicrosoftMyDay()
    126126{
    127     static bool isMicrosoftMyDay = applicationBundleIsEqualTo("com.microsoft.myday");
     127    static bool isMicrosoftMyDay = applicationBundleIsEqualTo(ASCIILiteral("com.microsoft.myday"));
    128128    return isMicrosoftMyDay;
    129129}
    … …  
    131131bool MacApplication::isMicrosoftOutlook()
    132132{
    133     static bool isMicrosoftOutlook = applicationBundleIsEqualTo("com.microsoft.Outlook");
     133    static bool isMicrosoftOutlook = applicationBundleIsEqualTo(ASCIILiteral("com.microsoft.Outlook"));
    134134    return isMicrosoftOutlook;
    135135}
    … …  
    137137bool MacApplication::isQuickenEssentials()
    138138{
    139     static bool isQuickenEssentials = applicationBundleIsEqualTo("com.intuit.QuickenEssentials");
     139    static bool isQuickenEssentials = applicationBundleIsEqualTo(ASCIILiteral("com.intuit.QuickenEssentials"));
    140140    return isQuickenEssentials;
    141141}
    … …  
    143143bool MacApplication::isAperture()
    144144{
    145     static bool isAperture = applicationBundleIsEqualTo("com.apple.Aperture");
     145    static bool isAperture = applicationBundleIsEqualTo(ASCIILiteral("com.apple.Aperture"));
    146146    return isAperture;
    147147}
    … …  
    149149bool MacApplication::isVersions()
    150150{
    151     static bool isVersions = applicationBundleIsEqualTo("com.blackpixel.versions");
     151    static bool isVersions = applicationBundleIsEqualTo(ASCIILiteral("com.blackpixel.versions"));
    152152    return isVersions;
    153153}
    … …  
    155155bool MacApplication::isHRBlock()
    156156{
    157     static bool isHRBlock = applicationBundleIsEqualTo("com.hrblock.tax.2010");
     157    static bool isHRBlock = applicationBundleIsEqualTo(ASCIILiteral("com.hrblock.tax.2010"));
    158158    return isHRBlock;
    159159}
    … …  
    161161bool MacApplication::isIAdProducer()
    162162{
    163     static bool isIAdProducer = applicationBundleIsEqualTo("com.apple.iAdProducer");
     163    static bool isIAdProducer = applicationBundleIsEqualTo(ASCIILiteral("com.apple.iAdProducer"));
    164164    return isIAdProducer;
    165165}
    … …  
    167167bool MacApplication::isSolidStateNetworksDownloader()
    168168{
    169     static bool isSolidStateNetworksDownloader = applicationBundleIsEqualTo("com.solidstatenetworks.awkhost");
     169    static bool isSolidStateNetworksDownloader = applicationBundleIsEqualTo(ASCIILiteral("com.solidstatenetworks.awkhost"));
    170170    return isSolidStateNetworksDownloader;
    171171}
    … …  
    177177bool IOSApplication::isMobileMail()
    178178{
    179     static bool isMobileMail = applicationBundleIsEqualTo("com.apple.mobilemail");
     179    static bool isMobileMail = applicationBundleIsEqualTo(ASCIILiteral("com.apple.mobilemail"));
    180180    return isMobileMail;
    181181}
    … …  
    183183bool IOSApplication::isMobileSafari()
    184184{
    185     static bool isMobileSafari = applicationBundleIsEqualTo("com.apple.mobilesafari");
     185    static bool isMobileSafari = applicationBundleIsEqualTo(ASCIILiteral("com.apple.mobilesafari"));
    186186    return isMobileSafari;
    187187}
    … …  
    189189bool IOSApplication::isWebBookmarksD()
    190190{
    191     static bool isWebBookmarksD = applicationBundleIsEqualTo("com.apple.webbookmarksd");
     191    static bool isWebBookmarksD = applicationBundleIsEqualTo(ASCIILiteral("com.apple.webbookmarksd"));
    192192    return isWebBookmarksD;
    193193}
    … …  
    197197    // We use a prefix match instead of strict equality since multiple instances of DumpRenderTree
    198198    // may be launched, where the bundle identifier of each instance has a unique suffix.
    199     static bool isDumpRenderTree = applicationBundleIsEqualTo("org.webkit.DumpRenderTree"); // e.g. org.webkit.DumpRenderTree0
     199    static bool isDumpRenderTree = applicationBundleIsEqualTo(ASCIILiteral("org.webkit.DumpRenderTree")); // e.g. org.webkit.DumpRenderTree0
    200200    return isDumpRenderTree;
    201201}
    … …  
    203203bool IOSApplication::isMobileStore()
    204204{
    205     static bool isMobileStore = applicationBundleIsEqualTo("com.apple.MobileStore");
     205    static bool isMobileStore = applicationBundleIsEqualTo(ASCIILiteral("com.apple.MobileStore"));
    206206    return isMobileStore;
    207207}
    … …  
    209209bool IOSApplication::isSpringBoard()
    210210{
    211     static bool isSpringBoard = applicationBundleIsEqualTo("com.apple.springboard");
     211    static bool isSpringBoard = applicationBundleIsEqualTo(ASCIILiteral("com.apple.springboard"));
    212212    return isSpringBoard;
    213213}
    … …  
    215215bool IOSApplication::isWebApp()
    216216{
    217     static bool isWebApp = applicationBundleIsEqualTo("com.apple.webapp");
     217    static bool isWebApp = applicationBundleIsEqualTo(ASCIILiteral("com.apple.webapp"));
    218218    return isWebApp;
    219219}
    … …  
    227227bool IOSApplication::isIBooks()
    228228{
    229     static bool isIBooks = applicationBundleIsEqualTo("com.apple.iBooks");
     229    static bool isIBooks = applicationBundleIsEqualTo(ASCIILiteral("com.apple.iBooks"));
    230230    return isIBooks;
    231231}
    … …  
    233233bool IOSApplication::isIBooksStorytime()
    234234{
    235     static bool isIBooksStorytime = applicationBundleIsEqualTo("com.apple.TVBooks");
     235    static bool isIBooksStorytime = applicationBundleIsEqualTo(ASCIILiteral("com.apple.TVBooks"));
    236236    return isIBooksStorytime;
    237237}
    … …  
    239239bool IOSApplication::isTheSecretSocietyHiddenMystery()
    240240{
    241     static bool isTheSecretSocietyHiddenMystery = applicationBundleIsEqualTo("com.g5e.secretsociety");
     241    static bool isTheSecretSocietyHiddenMystery = applicationBundleIsEqualTo(ASCIILiteral("com.g5e.secretsociety"));
    242242    return isTheSecretSocietyHiddenMystery;
    243243}
    … …  
    245245bool IOSApplication::isCardiogram()
    246246{
    247     static bool isCardiogram = applicationBundleIsEqualTo("com.cardiogram.ios.heart");
     247    static bool isCardiogram = applicationBundleIsEqualTo(ASCIILiteral("com.cardiogram.ios.heart"));
    248248    return isCardiogram;
    249249}
    … …  
    251251bool IOSApplication::isNike()
    252252{
    253     static bool isNike = applicationBundleIsEqualTo("com.nike.omega");
     253    static bool isNike = applicationBundleIsEqualTo(ASCIILiteral("com.nike.omega"));
    254254    return isNike;
    255255}
Note: See TracChangeset for help on using the changeset viewer.