Changeset 232241 in webkit

Timestamp:

May 28, 2018 3:15:45 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[Web Animations] Test webanimations/css-animations.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=186031

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2018-05-28
Reviewed by Antoine Quint.

This is another case of std::optional value being used while it's nullopt, I guess this started to fail when we
stopped using the WTF implementation of std::optional. The problem is that we try to get the current iteration
of a declarative animation when the active time is unresolved.

• animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::invalidateDOMEvents): Use value_or(0) instead of value() to get the current
iteration of the effect.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• animation/DeclarativeAnimation.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [Web Animations] Test webanimations/css-animations.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=186031
+
+        Reviewed by Antoine Quint.
+
+        This is another case of std::optional value being used while it's nullopt, I guess this started to fail when we
+        stopped using the WTF implementation of std::optional. The problem is that we try to get the current iteration
+        of a declarative animation when the active time is unresolved.
+
+        * animation/DeclarativeAnimation.cpp:
+        (WebCore::DeclarativeAnimation::invalidateDOMEvents): Use value_or(0) instead of value() to get the current
+        iteration of the effect.
+
 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
 

trunk/Source/WebCore/animation/DeclarativeAnimation.cpp

@@ -124 +124 @@
 
     auto isPending = pending();
-    auto iteration = animationEffect ? animationEffect->currentIteration().value() : 0;
+    auto iteration = animationEffect ? animationEffect->currentIteration().value_or(0) : 0;
     auto currentPhase = animationEffect ? animationEffect->phase() : phaseWithoutEffect();