Changeset 232343 in webkit

Timestamp:

May 31, 2018 3:20:54 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

test262-runner should run in verbose mode in automation
​https://bugs.webkit.org/show_bug.cgi?id=186115

Patch by Leo Balter <Leo Balter> on 2018-05-31
Reviewed by Yusuke Suzuki.

This patch toggles the verbose mode in the build bot and reports every test file
in order to avoid the '1200 seconds without output' issue.

• BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunTest262Tests):

• Scripts/test262/Runner.pm:

(processResult):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/steps.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• Scripts/test262/Runner.pm (modified) (2 diffs)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py

@@ -368 +368 @@
     descriptionDone = ["test262-tests"]
     failedTestsFormatString = "%d Test262 test%s failed"
-    command = ["perl", "./Tools/Scripts/test262-runner", WithProperties("--%(configuration)s")]
+    command = ["perl", "./Tools/Scripts/test262-runner", "--verbose", WithProperties("--%(configuration)s")]
 
     def start(self):

trunk/Tools/ChangeLog

@@ +1 @@
+2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
+
+        test262-runner should run in verbose mode in automation
+        https://bugs.webkit.org/show_bug.cgi?id=186115
+
+        Reviewed by Yusuke Suzuki.
+
+        This patch toggles the verbose mode in the build bot and reports every test file
+        in order to avoid the '1200 seconds without output' issue.
+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
+        (RunTest262Tests):
+        * Scripts/test262/Runner.pm:
+        (processResult):
+
 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Tools/Scripts/test262/Runner.pm

@@ -684 +684 @@
             my $featuresList = '';
             $featuresList = "\nFeatures: " . join(', ', @{ $data->{features} }) if $data->{features};
-            $suffixMsg = "$result$featuresList\n\n";
+            $suffixMsg = "$result$featuresList\n";
         }
 
@@ -694 +694 @@
         if ($expectedfailure) {
             print "NEW PASS $file ($scenario)\n";
-            print "\n" if $verbose;
+        } elsif ($verbose) {
+            print "PASS $file ($scenario)\n";
         }
 
         $resultdata{result} = 'PASS';
     } else {
+        if ($verbose) {
+            print "SKIP $file\n";
+        }
         $resultdata{result} = 'SKIP';
     }