Changeset 232413 in webkit


Ignore:
Timestamp:
Jun 1, 2018 1:41:04 PM (6 years ago)
Author:
dbates@webkit.org
Message:

http/tests/inspector/network/har/har-page.html should actually sort dumped cookies by name
​https://bugs.webkit.org/show_bug.cgi?id=186137

Reviewed by Joseph Pecoraro.

JavaScript does not support comparison of String data types using the minus operator. Instead
implement the string comparator using relational operators and the identity operator.

  • http/tests/inspector/network/har/har-page-expected.txt:
  • http/tests/inspector/network/har/har-page.html:
  • platform/gtk/TestExpectations: Unskip test.
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r232409 r232413  
     12018-06-01  Daniel Bates  <dabates@apple.com>
     2
     3        http/tests/inspector/network/har/har-page.html should actually sort dumped cookies by name
     4        https://bugs.webkit.org/show_bug.cgi?id=186137
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        JavaScript does not support comparison of String data types using the minus operator. Instead
     9        implement the string comparator using relational operators and the identity operator.
     10
     11        * http/tests/inspector/network/har/har-page-expected.txt:
     12        * http/tests/inspector/network/har/har-page.html:
     13        * platform/gtk/TestExpectations: Unskip test.
     14
    1152018-06-01  Youenn Fablet  <youenn@apple.com>
    216

  • trunk/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt

    r232318 r232413  
    541541            },
    542542            {
     543              "name": "same-site-strict",
     544              "value": "same-site-strict"
     545            },
     546            {
    543547              "name": "simple",
    544548              "value": "simple"
    … …  
    547551              "name": "with-expiration",
    548552              "value": "with-expiration"
    549             },
    550             {
    551               "name": "same-site-strict",
    552               "value": "same-site-strict"
    553553            }
    554554          ],
    … …  
    608608            },
    609609            {
     610              "name": "same-site-implicit-strict",
     611              "value": "same-site-implicit-strict"
     612            },
     613            {
     614              "name": "same-site-strict",
     615              "value": "same-site-strict"
     616            },
     617            {
    610618              "name": "simple",
    611619              "value": "simple"
    … …  
    614622              "name": "with-expiration",
    615623              "value": "with-expiration"
    616             },
    617             {
    618               "name": "same-site-implicit-strict",
    619               "value": "same-site-implicit-strict"
    620             },
    621             {
    622               "name": "same-site-strict",
    623               "value": "same-site-strict"
    624624            }
    625625          ],
    … …  
    679679            },
    680680            {
     681              "name": "same-site-implicit-strict",
     682              "value": "same-site-implicit-strict"
     683            },
     684            {
     685              "name": "same-site-strict",
     686              "value": "same-site-strict"
     687            },
     688            {
     689              "name": "same-site-strict-because-invalid-SameSite-value",
     690              "value": "same-site-strict-because-invalid-SameSite-value"
     691            },
     692            {
    681693              "name": "simple",
    682694              "value": "simple"
    … …  
    685697              "name": "with-expiration",
    686698              "value": "with-expiration"
    687             },
    688             {
    689               "name": "same-site-implicit-strict",
    690               "value": "same-site-implicit-strict"
    691             },
    692             {
    693               "name": "same-site-strict",
    694               "value": "same-site-strict"
    695             },
    696             {
    697               "name": "same-site-strict-because-invalid-SameSite-value",
    698               "value": "same-site-strict-because-invalid-SameSite-value"
    699699            }
    700700          ],

  • trunk/LayoutTests/http/tests/inspector/network/har/har-page.html

    r232318 r232413  
    5151        }
    5252
    53         // Sort cookies by name to make cookie order deterministic between test runs.
    54         if (key === "cookies")
    55             value.sort((a, b) => { return a.name - b.name; });
     53        // Sort cookies by name to make cookie order deterministic between test runs. We assume
     54        // that cookies have names that consist of only ASCII characters.
     55        if (key === "cookies") {
     56            value.sort((a, b) => { return a.name === b.name ? 0 : (a.name < b.name ? -1 : 1); });
     57            return value;
     58        }
    5659
    5760        // Since cache may or may not be used, timing data may be variable.

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r232344 r232413  
    34083408webkit.org/b/186100 fast/hidpi/filters-turbulence.html [ ImageOnlyFailure ]
    34093409
    3410 webkit.org/b/186137 http/tests/inspector/network/har/har-page.html [ Failure ]
    3411 
    34123410webkit.org/b/186138 imported/mozilla/css-transitions/test_event-dispatch.html [ Failure ]
    34133411
Note: See TracChangeset for help on using the changeset viewer.