Changeset 232603 in webkit
- Timestamp:
- Jun 7, 2018 3:07:37 PM (6 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r232591 r232603 1 2018-06-07 Mark Lam <mark.lam@apple.com> 2 3 Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run. 4 https://bugs.webkit.org/show_bug.cgi?id=186409 5 <rdar://problem/40909007> 6 7 Reviewed by Saam Barati. 8 9 * js/script-tests/intl-pluralrules.js: 10 1 11 2018-06-07 Ryosuke Niwa <rniwa@webkit.org> 2 12 -
trunk/LayoutTests/js/script-tests/intl-pluralrules.js
r231892 r232603 1 1 //@ skip if $hostOS == "windows" or $hostOS == "linux" 2 //@ requireOptions("--useIntlPluralRules=true") 3 2 4 description("This test checks the behavior of Intl.PluralRules as described in the ECMAScript Internationalization API Specification."); 3 5 -
trunk/Tools/ChangeLog
r232593 r232603 1 2018-06-07 Mark Lam <mark.lam@apple.com> 2 3 Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run. 4 https://bugs.webkit.org/show_bug.cgi?id=186409 5 <rdar://problem/40909007> 6 7 Reviewed by Saam Barati. 8 9 This is needed because some tests are written with specific features in mind, and 10 we may not necessarily want to enable that option for all tests. 11 12 We can now specify something like this at the top of a test file: 13 //@ requireOptions("--useIntlPluralRules=true") 14 15 ... and ensure that that test will be run with the --useIntlPluralRules=true 16 option for all test configurations that run the test. 17 18 * Scripts/run-jsc-stress-tests: 19 1 20 2018-06-07 Tim Horton <timothy_horton@apple.com> 2 21 -
trunk/Tools/Scripts/run-jsc-stress-tests
r231122 r232603 504 504 505 505 $runCommandOptions = {} 506 $testSpecificRequiredOptions = [] 506 507 507 508 $uniqueFilenameCounter = 0 … … 573 574 end 574 575 576 def requireOptions(*options) 577 $testSpecificRequiredOptions += options 578 end 579 575 580 def runWithOutputHandler(kind, outputHandler, *options) 576 addRunCommand(kind, [pathToVM.to_s] + BASE_OPTIONS + options + [$benchmark.to_s], outputHandler, simpleErrorHandler)581 addRunCommand(kind, [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions + options + [$benchmark.to_s], outputHandler, simpleErrorHandler) 577 582 end 578 583 … … 915 920 prepareExtraRelativeFiles(includeFiles.map { |f| "../" + f }, $collection) 916 921 917 args = [pathToVM.to_s] + BASE_OPTIONS 922 args = [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions 918 923 args << "--exception=" + exception if failsWithException 919 924 args << "--test262-async" if isAsync … … 957 962 958 963 def runES6(mode) 959 args = [pathToVM.to_s] + BASE_OPTIONS + [$benchmark.to_s]964 args = [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions + [$benchmark.to_s] 960 965 case mode 961 966 when :normal … … 1088 1093 prepareExtraRelativeFiles(extraFiles.map { |f| "../" + f }, $collection) 1089 1094 1090 args = [pathToVM.to_s] + BASE_OPTIONS 1095 args = [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions 1091 1096 args += FTL_OPTIONS if $isFTLPlatform 1092 1097 args += EAGER_OPTIONS … … 1129 1134 prepareExtraAbsoluteFiles(LAYOUTTESTS_PATH, ["resources/standalone-pre.js", "resources/standalone-post.js"]) 1130 1135 1131 args = [pathToVM.to_s] + BASE_OPTIONS + options +1136 args = [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions + options + 1132 1137 [(Pathname.new("resources") + "standalone-pre.js").to_s, 1133 1138 $benchmark.to_s, … … 1269 1274 end 1270 1275 prepareExtraRelativeFiles(extraFiles.map{|v| (Pathname("..") + v).to_s}, $collection) 1271 args = [pathToVM.to_s] + BASE_OPTIONS + options + extraFiles.map{|v| v.to_s} + [$benchmark.to_s]1276 args = [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions + options + extraFiles.map{|v| v.to_s} + [$benchmark.to_s] 1272 1277 case mode 1273 1278 when :normal … … 1339 1344 1340 1345 def runNoisyTestImpl(kind, options, additionalEnv) 1341 addRunCommand(kind, [pathToVM.to_s] + BASE_OPTIONS + options + [$benchmark.to_s], noisyOutputHandler, noisyErrorHandler, *additionalEnv)1346 addRunCommand(kind, [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions + options + [$benchmark.to_s], noisyOutputHandler, noisyErrorHandler, *additionalEnv) 1342 1347 end 1343 1348 … … 1537 1542 1538 1543 $runCommandOptions = {} 1544 $testSpecificRequiredOptions = [] 1539 1545 defaultRun unless parseRunCommands 1540 1546 }
Note: See TracChangeset
for help on using the changeset viewer.