Changeset 232644 in webkit


Ignore:
Timestamp:
Jun 8, 2018 3:30:23 PM (6 years ago)
Author:
Darin Adler
Message:

[Cocoa] Minor ARC tidying of libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186396

Reviewed by Dan Bernstein.

  • Configurations/Base.xcconfig: Set CLANG_ENABLE_OBJC_ARC here as we will eventually be

doing in all the various Base.xcconfig files as we make progress on conversion.

  • Configurations/libwebrtc.xcconfig: Removed override of CLANG_ENABLE_OBJC_ARC here and

also removed five other redundant settings that match Base.xcconfig.

  • libwebrtc.xcodeproj/project.pbxproj: Removed explicit -fobjc-arc that was set on

one particular source file, since that's already the default for the project.

Location:
trunk/Source/ThirdParty/libwebrtc
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/ThirdParty/libwebrtc/ChangeLog

    r232469 r232644  
     12018-06-07  Darin Adler  <darin@apple.com>
     2
     3        [Cocoa] Minor ARC tidying of libwebrtc
     4        https://bugs.webkit.org/show_bug.cgi?id=186396
     5
     6        Reviewed by Dan Bernstein.
     7
     8        * Configurations/Base.xcconfig: Set CLANG_ENABLE_OBJC_ARC here as we will eventually be
     9        doing in all the various Base.xcconfig files as we make progress on conversion.
     10
     11        * Configurations/libwebrtc.xcconfig: Removed override of CLANG_ENABLE_OBJC_ARC here and
     12        also removed five other redundant settings that match Base.xcconfig.
     13
     14        * libwebrtc.xcodeproj/project.pbxproj: Removed explicit -fobjc-arc that was set on
     15        one particular source file, since that's already the default for the project.
     16
    1172018-06-04  Youenn Fablet  <youenn@apple.com>
    218
  • trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig

    r230824 r232644  
    1010CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
    1111CLANG_CXX_LIBRARY = libc++;
     12CLANG_ENABLE_OBJC_ARC = YES;
    1213CLANG_ENABLE_OBJC_WEAK = YES;
    1314CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
  • trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig

    r231459 r232644  
    1818DYLIB_INSTALL_NAME_BASE_WK_RELOCATABLE_FRAMEWORKS_YES = @loader_path/../../../;
    1919
    20 CLANG_ENABLE_OBJC_ARC = YES;
    21 
    22 CLANG_WARN_BOOL_CONVERSION = YES;
    23 CLANG_WARN_ENUM_CONVERSION = YES;
    24 CLANG_WARN_INT_CONVERSION = YES;
    2520GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
    26 COMBINE_HIDPI_IMAGES = NO;
    27 ENABLE_STRICT_OBJC_MSGSEND = YES;
    2821HEADER_SEARCH_PATHS = Source Source/third_party/jsoncpp/source/include Source/third_party/libsrtp/crypto/include Source/third_party/libsrtp/include Source/third_party/boringssl/src/include Source/third_party/libyuv/include Source/third_party/usrsctp/usrsctplib Source/third_party/usrsctp/usrsctplib/usrsctplib Source/webrtc/sdk/objc/Framework/Headers Source/webrtc/common_audio/signal_processing/include Source/webrtc/modules/audio_coding/codecs/isac/main/include Source/third_party/opus/src/celt Source/third_party/opus/src/include Source/third_party/opus/src/src Source/webrtc/modules/audio_device/mac Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet Source/webrtc/modules/audio_device/ios;
    2922
  • trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

    r232236 r232644  
    27462746                5CFD53801E4BA4F500482908 /* audio_session_observer.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53791E4BA4F500482908 /* audio_session_observer.h */; };
    27472747                5CFD53811E4BA4F500482908 /* voice_processing_audio_unit.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD537A1E4BA4F500482908 /* voice_processing_audio_unit.h */; };
    2748                 5CFD53821E4BA4F500482908 /* voice_processing_audio_unit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD537B1E4BA4F500482908 /* voice_processing_audio_unit.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
     2748                5CFD53821E4BA4F500482908 /* voice_processing_audio_unit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD537B1E4BA4F500482908 /* voice_processing_audio_unit.mm */; };
    27492749                5CFD538D1E4BD3A300482908 /* compare_neon.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53851E4BD3A300482908 /* compare_neon.cc */; };
    27502750                5CFD538E1E4BD3A300482908 /* compare_neon64.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53861E4BD3A300482908 /* compare_neon64.cc */; };
Note: See TracChangeset for help on using the changeset viewer.