Changeset 232736 in webkit

Timestamp:

Jun 11, 2018 5:11:02 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Layout Test svg/dom/animated-tearoff-list-remove-target.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=185698
<rdar://problem/40341200>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-06-11
Reviewed by Daniel Bates.

The test is flaky because we get the animVal.getItem(0) of the 'x' attribute
from the target element without initializing this attribute with a base value.

The test assumes the animator would set the animVal of the 'x' attribute
from the 'from' attribute of the <animate> element before animVal.getItem(0)
is executed. But this may not always happen. Therefore the test will get
the 'IndexSizeError' exception and it will time out.

The fix is:
-- Initialize the attribute of the target element by a base value.
-- Use requestAnimationFrame() instead of using setTimeout() to make the

test deterministic.

-- Allow the animation to advance one more step after kicking off the GC

to ensure the variable 'animItem' is detached from animVal.getItem(0).

• svg/dom/animated-tearoff-list-remove-target.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• svg/dom/animated-tearoff-list-remove-target.html (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-06-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Layout Test svg/dom/animated-tearoff-list-remove-target.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=185698
+        <rdar://problem/40341200>
+
+        Reviewed by Daniel Bates.
+
+        The test is flaky because we get the animVal.getItem(0) of the 'x' attribute
+        from the target element without initializing this attribute with a base value.
+
+        The test assumes the animator would set the animVal of the 'x' attribute
+        from the 'from' attribute of the <animate> element before animVal.getItem(0)
+        is executed. But this may not always happen. Therefore the test will get 
+        the 'IndexSizeError' exception and it will time out.
+
+        The fix is:
+        -- Initialize the attribute of the target element by a base value.
+        -- Use requestAnimationFrame() instead of using setTimeout() to make the
+           test deterministic.
+        -- Allow the animation to advance one more step after kicking off the GC
+           to ensure the variable 'animItem' is detached from animVal.getItem(0).
+
+        * svg/dom/animated-tearoff-list-remove-target.html:
+
 2018-06-11  Jer Noble  <jer.noble@apple.com>
 

trunk/LayoutTests/svg/dom/animated-tearoff-list-remove-target.html

@@ -4 +4 @@
     <svg>
         <text x="15" y="40">
-            <tspan id="first-tspan">First tspan.</tspan> 
+            <tspan id="first-tspan" x="0">First tspan.</tspan> 
         </text>
         <text x="15" y="60">
-            <tspan id="second-tspan">Second tspan</tspan> 
+            <tspan id="second-tspan" x="0">Second tspan</tspan> 
         </text>
         <animate id="animate" xlink:href="#first-tspan" attributeType="XML" attributeName="x" from="0" to="100" dur="10s" repeatCount="indefinite"/>
@@ -27 +27 @@
             }
 
-            setTimeout(() => {
+            window.requestAnimationFrame(() => {
                 // The target of the <animate> element is the "first-tspan".
                 var tspanElement = document.getElementById("first-tspan");
@@ -42 +42 @@
                 // of an SVGLength. animItem should not be affected if garbage collection is forced.
                 gc();
-                if (animItem.valueAsString == "0") {
-                    document.querySelector("div").innerHTML += "<br><br>PASS."
-                    document.querySelector("svg").remove();
-                }
+                window.requestAnimationFrame(() => {
+                    if (animItem.valueAsString == "0") {
+                        document.querySelector("div").innerHTML += "<br><br>PASS."
+                        document.querySelector("svg").remove();
+                    }
 
-                if (window.testRunner)
-                    testRunner.notifyDone();
-            }, 0);
+                    if (window.testRunner)
+                        testRunner.notifyDone();
+                });
+            });
         })();
     </script>